Changing style, logging to window, more logging.

This redirects all logging output to the main window. Previously only some log levels were sent to the console, so now the state of the get request is more transparent.

The different error levels are printed with separate color bands to increase readability.

R=tapted@chromium.org

Committed: https://github.com/tapted/bleeding_edge/commit/fef9d75

[tapted, 2014-01-13 23:19:10]

Remember to put a description into your CL descriptions, not just a title.

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/app...
File dart/sdk/lib/_internal/pub/app/pub.html (right):

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/app...
dart/sdk/lib/_internal/pub/app/pub.html:11: <textarea
id="logtext"></textarea><br>
I'd maybe try out something like

<div id="logtext" style="border: 1px solid; height: 80%; width: 80%; overflow-y:
scroll"></div>

Then you can pass 'level' into your logging function and make it pretty colours
depending on wether it is an error/warning/info/etc. -WDYT?

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/app/pubchrome.dart (right):

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/app/pubchrome.dart:29:
log.addLoggerFunction((msg) => logtext.text += msg);
I think dart auto-sanitizes some things.. but it would be good to check that if
`logtext.text`contains ampersands or angle brackets it doesn't break the page.

But with my earlier suggestion, it would be something like

void logToWindow(String line, String level) {
  var line_div = new DivElement();
  line_div.text = line;  // Pretty sure this escapes things, but check.
  line_div.classes.add("log_$level");
  logtext.children.add(line_div);
  logtext.children.add(BRElement());
}

Then add css rules for class ERR/WARN/MSG/IO/FINE

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/log.dart (right):

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:125: for (var otherLogFunction in
otherLogFunctions)
I'd probably move this out if the `if`. Also this `for` needs curlies, since it
is multi-line.

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:127: otherLogFunction("$line\n");
and pass level.name (or Level itself) in here, but don't append a new line
character (i.e. just pass `line` not `"$line\n"` -- the logger function should
decide.

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:133: List<Function>
otherLogFunctions = new List<Function>();
This dec should go up around line 36, and have a leading underscore.

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:135: void addLoggerFunction(void
logFn(String message)) {
nit: `logFn -> logFunction` -- google style is to not abbreviate

[pajamallama, 2014-01-14 02:29:01]

Beautiful

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/app...
File dart/sdk/lib/_internal/pub/app/pub.html (right):

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/app...
dart/sdk/lib/_internal/pub/app/pub.html:11: <textarea
id="logtext"></textarea><br>
On 2014/01/13 23:19:10, tapted wrote:
> I'd maybe try out something like
> 
> <div id="logtext" style="border: 1px solid; height: 80%; width: 80%;
overflow-y:
> scroll"></div>
> 
> Then you can pass 'level' into your logging function and make it pretty
colours
> depending on wether it is an error/warning/info/etc. -WDYT?

Done.

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/app/pubchrome.dart (right):

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/app/pubchrome.dart:29:
log.addLoggerFunction((msg) => logtext.text += msg);
On 2014/01/13 23:19:10, tapted wrote:
> I think dart auto-sanitizes some things.. but it would be good to check that
if
> `logtext.text`contains ampersands or angle brackets it doesn't break the page.
> 
> But with my earlier suggestion, it would be something like
> 
> void logToWindow(String line, String level) {
>   var line_div = new DivElement();
>   line_div.text = line;  // Pretty sure this escapes things, but check.
>   line_div.classes.add("log_$level");
>   logtext.children.add(line_div);
>   logtext.children.add(BRElement());
> }
> 
> Then add css rules for class ERR/WARN/MSG/IO/FINE

Done.

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/log.dart (right):

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:125: for (var otherLogFunction in
otherLogFunctions)
On 2014/01/13 23:19:10, tapted wrote:
> I'd probably move this out if the `if`. Also this `for` needs curlies, since
it
> is multi-line.

I had this inside the if statement so that setting the logging output  threshold
(via log.showAll(), log.showDebug() etc.) will also change the level output to
this textarea. Added curlies.

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:127: otherLogFunction("$line\n");
On 2014/01/13 23:19:10, tapted wrote:
> and pass level.name (or Level itself) in here, but don't append a new line
> character (i.e. just pass `line` not `"$line\n"` -- the logger function should
> decide.

Done.

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:133: List<Function>
otherLogFunctions = new List<Function>();
On 2014/01/13 23:19:10, tapted wrote:
> This dec should go up around line 36, and have a leading underscore.

Done.

https://codereview.appspot.com/51060043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:135: void addLoggerFunction(void
logFn(String message)) {
On 2014/01/13 23:19:10, tapted wrote:
> nit: `logFn -> logFunction` -- google style is to not abbreviate

Done.

[tapted, 2014-01-14 05:38:21]

lgtm with a nit and a move verbose CL description

https://codereview.appspot.com/51060043/diff/40001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/lib/src/log.dart (right):

https://codereview.appspot.com/51060043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/lib/src/log.dart:36: List<Function>
_otherLogFunctions = new List<Function>();
nit: should give it a comment, to be consistent.

[pajamallama, 2014-01-14 05:52:57]

Committed patchset #3 manually as rfef9d75 (presubmit successful).