Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(520)

Issue 51010046: Clear queues at ingest startup.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by bac
Modified:
10 years, 3 months ago
Reviewers:
rharding, mp+201945
Visibility:
Public.

Description

Clear queues at ingest startup. Bundles seem to get stuck when the job entries are locked and the ingest process dies, such as happens when charm attributes are set or the charm gets updated. To avoid having the queues littered with items that never go away, which is disconcerting to the casual viewer of /heartbeat, this branch introduces a new --clear option to the queueing process which is used by the worker on the first invocation This branch also addresses a few other issues by being more defensive in the face of charms and bundles that are non-standard in a number of ways. * Handle the lack of 'bundles.yaml' gracefully. * Handle SVG files with float placement values. * Handle charms with no files. The only instance I've seen of this occurring is with a charm that is private in Launchpad, so I cannot assess how it happens. https://code.launchpad.net/~bac/charmworld/fix-ingestion-errors/+merge/201945 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -31 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/jobs/ingest.py View 3 chunks +25 lines, -13 lines 1 comment Download
M charmworld/jobs/lp.py View 3 chunks +23 lines, -8 lines 0 comments Download
M charmworld/jobs/supervisord.conf View 1 chunk +1 line, -1 line 0 comments Download
M charmworld/jobs/tests/test_ingest.py View 1 chunk +18 lines, -0 lines 0 comments Download
M charmworld/jobs/tests/test_lp.py View 3 chunks +39 lines, -1 line 0 comments Download
M charmworld/jobs/tests/test_scan.py View 1 chunk +20 lines, -0 lines 0 comments Download
M charmworld/jobs/tests/test_worker.py View 2 chunks +9 lines, -1 line 0 comments Download
M charmworld/jobs/worker.py View 1 chunk +3 lines, -0 lines 0 comments Download
M charmworld/models.py View 1 chunk +2 lines, -2 lines 1 comment Download
M charmworld/tests/test_lp.py View 1 chunk +1 line, -1 line 0 comments Download
M charmworld/tests/test_models.py View 3 chunks +88 lines, -4 lines 1 comment Download

Messages

Total messages: 4
bac
Please take a look.
10 years, 3 months ago (2014-01-16 15:21:43 UTC) #1
bac
QA: In one terminal % make run Open your browser and go to /heartbeat. Verify ...
10 years, 3 months ago (2014-01-16 15:41:15 UTC) #2
rharding
LGTM with a couple of comments. QA starting. https://codereview.appspot.com/51010046/diff/1/charmworld/jobs/ingest.py File charmworld/jobs/ingest.py (right): https://codereview.appspot.com/51010046/diff/1/charmworld/jobs/ingest.py#newcode411 charmworld/jobs/ingest.py:411: self.log.error('No ...
10 years, 3 months ago (2014-01-16 17:34:34 UTC) #3
rharding
10 years, 3 months ago (2014-01-16 17:38:08 UTC) #4
QA ok
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b