Issue 50960043: code review 50960043: syscall: remove getsockname workaround for openbsd

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 50960043: code review 50960043: syscall: remove getsockname workaround for openbsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by jsing

Modified:
11 years, 6 months ago

Reviewers:
minux1

CC:
golang-codereviews, minux1

Visibility:
Public.

Description

syscall: remove getsockname workaround for openbsd Remove the getsockname workaround for unix domain sockets on OpenBSD. This was fixed in OpenBSD 5.2 and we now have a minimum requirement for OpenBSD 5.4-current.

Patch Set 1 #

Patch Set 2 : diff -r 7ecbc2b8ec97 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7ecbc2b8ec97 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7ecbc2b8ec97 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 08b5c68af150 https://go.googlecode.com/hg/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	src/pkg/syscall/syscall_bsd.go	View	1 2	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jsing

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2014-01-12 15:25:29 UTC) #1

jsing

11 years, 6 months ago (2014-01-13 00:25:04 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a2c4114981d6 ***

syscall: remove getsockname workaround for openbsd

Remove the getsockname workaround for unix domain sockets on OpenBSD.
This was fixed in OpenBSD 5.2 and we now have a minimum requirement
for OpenBSD 5.4-current.

R=golang-codereviews, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/50960043

Expand All Messages | Collapse All Messages