Issue 50930043: code review 50930043: syscall: include mmap constants in openbsd zerror* files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 50930043: code review 50930043: syscall: include mmap constants in openbsd zerror* files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by jsing

Modified:
11 years, 6 months ago

Reviewers:
minux1

CC:
golang-codereviews, minux1

Visibility:
Public.

Description

syscall: include mmap constants in openbsd zerror* files Include the <sys/mman.h> header for OpenBSD mkerrors.sh. This brings in constants used with madvise(2), mmap(2), msync(2) and mlockall(2). Fixes issue 4929

Patch Set 1 #

Patch Set 2 : diff -r 7ecbc2b8ec97 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7ecbc2b8ec97 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7ecbc2b8ec97 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a2c4114981d6 https://go.googlecode.com/hg/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -0 lines)			Patch
M	src/pkg/syscall/mkerrors.sh	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_openbsd_386.go	View	1 2	3 chunks	+33 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_openbsd_amd64.go	View	1	3 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jsing

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2014-01-12 15:35:18 UTC) #1

jsing

11 years, 6 months ago (2014-01-13 00:25:57 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=270e6a19b4ec ***

syscall: include mmap constants in openbsd zerror* files

Include the <sys/mman.h> header for OpenBSD mkerrors.sh. This brings
in constants used with madvise(2), mmap(2), msync(2) and mlockall(2).

Fixes issue 4929

R=golang-codereviews, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/50930043

Expand All Messages | Collapse All Messages