Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11636)

Issue 50920043: code review 50920043: leveldb-go: implement file lock on openbsd/amd64.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by marraison
Modified:
10 years, 3 months ago
Reviewers:
CC:
nigeltao, golang-codereviews
Visibility:
Public.

Description

leveldb-go: implement file lock on openbsd/amd64.

Patch Set 1 #

Patch Set 2 : diff -r a2c0ed4d6198 https://code.google.com/p/leveldb-go #

Patch Set 3 : diff -r a2c0ed4d6198 https://code.google.com/p/leveldb-go #

Patch Set 4 : diff -r a2c0ed4d6198 https://code.google.com/p/leveldb-go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M leveldb/db/file_lock_generic.go View 1 1 chunk +1 line, -0 lines 0 comments Download
A leveldb/db/file_lock_openbsd_amd64.go View 1 2 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 5
marraison
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com, nigeltao@golang.org), I'd like you to review this change to https://code.google.com/p/leveldb-go
10 years, 3 months ago (2014-01-12 14:35:49 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
10 years, 3 months ago (2014-01-12 14:39:29 UTC) #2
nigeltao
I presume that you've run the manualtest/filelock program?
10 years, 3 months ago (2014-01-13 23:09:56 UTC) #3
marraison
On 2014/01/13 23:09:56, nigeltao wrote: > I presume that you've run the manualtest/filelock program? Yes ...
10 years, 3 months ago (2014-01-14 18:56:50 UTC) #4
nigeltao
10 years, 3 months ago (2014-01-20 03:49:50 UTC) #5
*** Submitted as
https://code.google.com/p/leveldb-go/source/detail?r=0b4dffc91e3b ***

leveldb-go: implement file lock on openbsd/amd64.

R=nigeltao
CC=golang-codereviews, nigeltao
https://codereview.appspot.com/50920043

Committer: Nigel Tao <nigeltao@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b