RNA write access for CurveMap

[lukas.toenne, 2011-09-21 11:57:32]

Further explanation:

Updating points in a CurveMap requires update calls on the CurveMapping struct.
Since this is unknown to the CurveMap itself, this has been disabled in the RNA
(CurveMap points are readonly, except for selection flag, which does not require
the update).

To work around this i added some RNA functions to CurveMapping, wrapping the C
functions used for this purpose. They take the curve map index as a required
parameter. The remove and set_handle functions work on all selected points (as
in C code), so in order to update specific points without messing up selection
one would have to save the selection state and restore later.

Not as elegant as direct CurveMapPoint functions, but a suitable workaround
imho.

[ideasman42, 2011-09-22 07:07:13]

Generally functionality is ok, but would like to have this match Curve and
FCurve style access, comments inline.

http://codereview.appspot.com/5091046/diff/1/source/blender/makesrna/intern/r...
File source/blender/makesrna/intern/rna_color.c (right):

http://codereview.appspot.com/5091046/diff/1/source/blender/makesrna/intern/r...
source/blender/makesrna/intern/rna_color.c:161: static void
rna_CurveMapping_set_point_handles(CurveMapping *cumap, int cuma_index, int
handle_type)
Why add this when we have CurveMapPoint.handle_type ???

http://codereview.appspot.com/5091046/diff/1/source/blender/makesrna/intern/r...
source/blender/makesrna/intern/rna_color.c:425: prop= RNA_def_property(srna,
"points", PROP_COLLECTION, PROP_NONE);
add/remove points function should be added here.

I'd like this to follow Bezier curve / FCurve api style where possible.

http://codereview.appspot.com/5091046/diff/1/source/blender/makesrna/intern/r...
source/blender/makesrna/intern/rna_color.c:486: func= RNA_def_function(srna,
"reset", "rna_CurveMapping_reset");
Rather then passing an index this should be a member of CurveMap.