Fix issue where default and rest params where dropped on the floor by the ClassTransformer.

Fix issue where default and rest params where dropped on the floor by the ClassTransformer.

BUG=http://code.google.com/p/traceur-compiler/issues/detail?id=39
TEST=test/feature/Classes/{Optional,Rest}Params.js

Committed: http://code.google.com/p/traceur-compiler/source/detail?r=317

[cburrows, 2011-09-19 05:45:38]

I think the pattern is to use a method from ParseTreeFactory and not the
constructor, right? Otherwise LGTM.

https://codereview.appspot.com/5066041/diff/1001/src/codegeneration/ClassTran...
File src/codegeneration/ClassTransformer.js (right):

https://codereview.appspot.com/5066041/diff/1001/src/codegeneration/ClassTran...
src/codegeneration/ClassTransformer.js:287: new FormalParameterList(null,
createParameterList(set.tree.parameter)?

[arv, 2011-09-19 16:27:16]

https://codereview.appspot.com/5066041/diff/1001/src/codegeneration/ClassTran...
File src/codegeneration/ClassTransformer.js (right):

https://codereview.appspot.com/5066041/diff/1001/src/codegeneration/ClassTran...
src/codegeneration/ClassTransformer.js:287: new FormalParameterList(null,
On 2011/09/19 05:45:38, cburrows wrote:
> createParameterList(set.tree.parameter)?

The old one was busted and this was the only caller. I've also been moving away
from creating createFoo functions where the gain is minimal.

[cburrows, 2011-09-19 16:41:16]

https://codereview.appspot.com/5066041/diff/1001/src/codegeneration/ClassTran...
File src/codegeneration/ClassTransformer.js (right):

https://codereview.appspot.com/5066041/diff/1001/src/codegeneration/ClassTran...
src/codegeneration/ClassTransformer.js:287: new FormalParameterList(null,
On 2011/09/19 16:27:17, arv1 wrote:
> On 2011/09/19 05:45:38, cburrows wrote:
> > createParameterList(set.tree.parameter)?
> 
> The old one was busted and this was the only caller. I've also been moving
away
> from creating createFoo functions where the gain is minimal.

createParameterList (not createParameter, which you deleted) does what you're
doing here.

[arv, 2011-09-19 16:54:55]

https://codereview.appspot.com/5066041/diff/1001/src/codegeneration/ClassTran...
File src/codegeneration/ClassTransformer.js (right):

https://codereview.appspot.com/5066041/diff/1001/src/codegeneration/ClassTran...
src/codegeneration/ClassTransformer.js:287: new FormalParameterList(null,
On 2011/09/19 16:41:16, cburrows wrote:
> On 2011/09/19 16:27:17, arv1 wrote:
> > On 2011/09/19 05:45:38, cburrows wrote:
> > > createParameterList(set.tree.parameter)?
> > 
> > The old one was busted and this was the only caller. I've also been moving
> away
> > from creating createFoo functions where the gain is minimal.
> 
> createParameterList (not createParameter, which you deleted) does what you're
> doing here.

It sure does. I'll reuse that instead. Thanks.