Issue 5066: use git log for review description

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5066: use git log for review description (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by Evan Martin

Modified:
14 years, 8 months ago

Reviewers:
hanwenn

Visibility:
Public.

Description

Use "git log" to construct the initial description and let the user edit it locally when creating an issue.

Patch Set 1 #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	M	git-cl	View		3 chunks	+41 lines, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hanwenn

LGTM http://codereview.appspot.com/5066/diff/1/2 File git-cl (right): http://codereview.appspot.com/5066/diff/1/2#newcode267 Line 267: stripcomment_re = re.compile(r'^#.*$', re.MULTILINE) re.sub() does this ...

15 years, 7 months ago (2008-09-11 01:55:58 UTC) #2

Evan Martin

15 years, 7 months ago (2008-09-11 02:40:16 UTC) #3

On 2008/09/11 01:55:58, hanwenn wrote:
> LGTM
> 
> http://codereview.appspot.com/5066/diff/1/2
> File git-cl (right):
> 
> http://codereview.appspot.com/5066/diff/1/2#newcode267
> Line 267: stripcomment_re = re.compile(r'^#.*$', re.MULTILINE)
> re.sub() does this implicitly.

Not the MULTILINE part, right?

> http://codereview.appspot.com/5066/diff/1/2#newcode301
> Line 301: # This will displayed on the codereview site.
> this should be indetned.

It's part of the multiline string above.

Expand All Messages | Collapse All Messages