Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(146)

Issue 5066: use git log for review description (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Evan Martin
Modified:
12 years, 3 months ago
Reviewers:
hanwenn
Visibility:
Public.

Description

Use "git log" to construct the initial description and let the user edit it locally when creating an issue.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M git-cl View 3 chunks +41 lines, -0 lines 2 comments Download

Messages

Total messages: 3
Evan Martin
13 years, 1 month ago (2008-09-10 21:35:40 UTC) #1
hanwenn
LGTM http://codereview.appspot.com/5066/diff/1/2 File git-cl (right): http://codereview.appspot.com/5066/diff/1/2#newcode267 Line 267: stripcomment_re = re.compile(r'^#.*$', re.MULTILINE) re.sub() does this ...
13 years, 1 month ago (2008-09-11 01:55:58 UTC) #2
Evan Martin
13 years, 1 month ago (2008-09-11 02:40:16 UTC) #3
On 2008/09/11 01:55:58, hanwenn wrote:
> LGTM
> 
> http://codereview.appspot.com/5066/diff/1/2
> File git-cl (right):
> 
> http://codereview.appspot.com/5066/diff/1/2#newcode267
> Line 267: stripcomment_re = re.compile(r'^#.*$', re.MULTILINE)
> re.sub() does this implicitly.

Not the MULTILINE part, right?

> http://codereview.appspot.com/5066/diff/1/2#newcode301
> Line 301: # This will displayed on the codereview site.
> this should be indetned.

It's part of the multiline string above.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b