Issue 5065: make email prompt more explicit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5065: make email prompt more explicit (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by Evan Martin

Modified:
14 years, 8 months ago

Reviewers:
Andi Albrecht, GvR, andi.albrecht

Visibility:
Public.

Description

Some users of git-cl were confused by the "Email:" prompt from uploading -- it wasn't clear to them whether this was their email, or the target of the review's email, or what.

Patch Set 1 #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	static/upload.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Andi Albrecht

Good idea! http://codereview.appspot.com/5065/diff/1/2 File static/upload.py (right): http://codereview.appspot.com/5065/diff/1/2#newcode429 Line 429: email = raw_input("Email (login for uploading ...

15 years, 7 months ago (2008-09-11 03:59:37 UTC) #1

Committed as r313.  Live.

Expand All Messages | Collapse All Messages