Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

Issue 5065: make email prompt more explicit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Evan Martin
Modified:
12 years, 3 months ago
Reviewers:
Andi Albrecht, GvR, andi.albrecht
Visibility:
Public.

Description

Some users of git-cl were confused by the "Email:" prompt from uploading -- it wasn't clear to them whether this was their email, or the target of the review's email, or what.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M static/upload.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 2
Andi Albrecht
Good idea! http://codereview.appspot.com/5065/diff/1/2 File static/upload.py (right): http://codereview.appspot.com/5065/diff/1/2#newcode429 Line 429: email = raw_input("Email (login for uploading ...
13 years, 1 month ago (2008-09-11 03:59:37 UTC) #1
GvR
13 years, 1 month ago (2008-09-16 17:51:09 UTC) #2
Committed as r313.  Live.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b