http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... File cpp/linux-specific/x_ignore_nofocus.c (left): http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... cpp/linux-specific/x_ignore_nofocus.c:243: stat->during_switch = FALSE; The equivalent to this unlink call would be to set start_switch_window and start_close_window to FALSE. http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... File cpp/linux-specific/x_ignore_nofocus.c (right): http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... cpp/linux-specific/x_ignore_nofocus.c:510: Leftover code? http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... cpp/linux-specific/x_ignore_nofocus.c:523: if (is_emulated_32bit() == FALSE) { Let's move this into a separate change. http://codereview.appspot.com/5043050/diff/1/cpp/webdriver-firefox/native_eve... File cpp/webdriver-firefox/native_events.cpp (right): http://codereview.appspot.com/5043050/diff/1/cpp/webdriver-firefox/native_eve... cpp/webdriver-firefox/native_events.cpp:55: #ifdef BUILD_ON_UNIX I prefer the functions' declarations to appear here, rather than including x_ignore_nofocus.h. Including it creates dependency in compilation between the two units which is not necessary (Including x_ignore_nofocus.h in the c file does not provide any additional protection). http://codereview.appspot.com/5043050/diff/1/javascript/firefox-driver/extens... File javascript/firefox-driver/extension/components/nsCommandProcessor.js (right): http://codereview.appspot.com/5043050/diff/1/javascript/firefox-driver/extens... javascript/firefox-driver/extension/components/nsCommandProcessor.js:479: // switch focus. Pass in the Window ID (even though it's only used for informative purposes) http://codereview.appspot.com/5043050/diff/1/javascript/firefox-driver/js/uti... File javascript/firefox-driver/js/utils.js (right): http://codereview.appspot.com/5043050/diff/1/javascript/firefox-driver/js/uti... javascript/firefox-driver/js/utils.js:76: Consistent naming: stick with notifyOfWindowClose
http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... File cpp/linux-specific/x_ignore_nofocus.c (left): http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... cpp/linux-specific/x_ignore_nofocus.c:243: stat->during_switch = FALSE; On 2011/09/26 13:28:26, Eran wrote: > The equivalent to this unlink call would be to set start_switch_window and > start_close_window to FALSE. Done. http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... File cpp/linux-specific/x_ignore_nofocus.c (right): http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... cpp/linux-specific/x_ignore_nofocus.c:510: On 2011/09/26 13:28:26, Eran wrote: > Leftover code? Done. http://codereview.appspot.com/5043050/diff/1/cpp/linux-specific/x_ignore_nofo... cpp/linux-specific/x_ignore_nofocus.c:523: if (is_emulated_32bit() == FALSE) { On 2011/09/26 13:28:26, Eran wrote: > Let's move this into a separate change. Done. http://codereview.appspot.com/5043050/diff/1/cpp/webdriver-firefox/native_eve... File cpp/webdriver-firefox/native_events.cpp (right): http://codereview.appspot.com/5043050/diff/1/cpp/webdriver-firefox/native_eve... cpp/webdriver-firefox/native_events.cpp:55: #ifdef BUILD_ON_UNIX On 2011/09/26 13:28:26, Eran wrote: > I prefer the functions' declarations to appear here, rather than including > x_ignore_nofocus.h. Including it creates dependency in compilation between the > two units which is not necessary (Including x_ignore_nofocus.h in the c file > does not provide any additional protection). Done. http://codereview.appspot.com/5043050/diff/1/javascript/firefox-driver/extens... File javascript/firefox-driver/extension/components/nsCommandProcessor.js (right): http://codereview.appspot.com/5043050/diff/1/javascript/firefox-driver/extens... javascript/firefox-driver/extension/components/nsCommandProcessor.js:479: // switch focus. On 2011/09/26 13:28:26, Eran wrote: > Pass in the Window ID (even though it's only used for informative purposes) Done. http://codereview.appspot.com/5043050/diff/1/javascript/firefox-driver/js/uti... File javascript/firefox-driver/js/utils.js (right): http://codereview.appspot.com/5043050/diff/1/javascript/firefox-driver/js/uti... javascript/firefox-driver/js/utils.js:76: On 2011/09/26 13:28:26, Eran wrote: > Consistent naming: stick with notifyOfWindowClose Done.
LGTM, only thing missing is the printout of the window id received in x_ignore_nofocus. Otherwise the tests pass and it's ready for committing.
Committed in r14011.
