Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 50420043: code review 50420043: runtime: output how long goroutines are blocked (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by dvyukov
Modified:
1 year, 4 months ago
Reviewers:
khr, rsc
CC:
golang-codereviews, khr, kisielk, bradfitz, rsc
Visibility:
Public.

Description

runtime: output how long goroutines are blocked Example of output: goroutine 4 [sleep for 3 min]: time.Sleep(0x34630b8a000) src/pkg/runtime/time.goc:31 +0x31 main.func·002() block.go:16 +0x2c created by main.main block.go:17 +0x33 Full program and output are here: http://play.golang.org/p/NEZdADI3Td Fixes issue 6809.

Patch Set 1 #

Patch Set 2 : diff -r 63dc9bf51514 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 63dc9bf51514 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 63dc9bf51514 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 3

Patch Set 5 : diff -r 209c0d648d9c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 209c0d648d9c https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M doc/go1.3.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 3 4 4 chunks +13 lines, -1 line 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10
dvyukov
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
1 year, 4 months ago (2014-01-10 11:44:53 UTC) #1
khr
LGTM. https://codereview.appspot.com/50420043/diff/60001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): https://codereview.appspot.com/50420043/diff/60001/src/pkg/runtime/mgc0.c#newcode1681 src/pkg/runtime/mgc0.c:1681: // needed only to output in traceback Can't ...
1 year, 4 months ago (2014-01-10 19:05:24 UTC) #2
kisielk
Is there a particular reason you chose to have the resolution in minutes instead of ...
1 year, 4 months ago (2014-01-10 20:00:07 UTC) #3
dvyukov
On Sat, Jan 11, 2014 at 12:00 AM, <kamil.kisiel@gmail.com> wrote: > Is there a particular ...
1 year, 4 months ago (2014-01-11 10:49:16 UTC) #4
dvyukov
https://codereview.appspot.com/50420043/diff/60001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): https://codereview.appspot.com/50420043/diff/60001/src/pkg/runtime/mgc0.c#newcode1681 src/pkg/runtime/mgc0.c:1681: // needed only to output in traceback On 2014/01/10 ...
1 year, 4 months ago (2014-01-13 07:08:53 UTC) #5
dvyukov
Anybody else? Any comments on the output format -- just appending " for 3 min" ...
1 year, 4 months ago (2014-01-13 07:10:20 UTC) #6
bradfitz
Maybe you have to ask golang-dev. On Jan 12, 2014 11:10 PM, <dvyukov@google.com> wrote: > ...
1 year, 4 months ago (2014-01-13 07:12:08 UTC) #7
rsc
LGTM https://codereview.appspot.com/50420043/diff/60001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/50420043/diff/60001/src/pkg/runtime/proc.c#newcode273 src/pkg/runtime/proc.c:273: runtime·printf("goroutine %D [%s for %D min]:\n", gp->goid, status, ...
1 year, 4 months ago (2014-01-13 16:31:41 UTC) #8
dvyukov
On 2014/01/13 16:31:41, rsc wrote: > LGTM > > https://codereview.appspot.com/50420043/diff/60001/src/pkg/runtime/proc.c > File src/pkg/runtime/proc.c (right): > ...
1 year, 4 months ago (2014-01-16 08:53:09 UTC) #9
dvyukov
1 year, 4 months ago (2014-01-16 08:58:40 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=ff8459d06e3f ***

runtime: output how long goroutines are blocked
Example of output:

goroutine 4 [sleep for 3 min]:
time.Sleep(0x34630b8a000)
        src/pkg/runtime/time.goc:31 +0x31
main.func·002()
        block.go:16 +0x2c
created by main.main
        block.go:17 +0x33

Full program and output are here:
http://play.golang.org/p/NEZdADI3Td

Fixes issue 6809.

R=golang-codereviews, khr, kamil.kisiel, bradfitz, rsc
CC=golang-codereviews
https://codereview.appspot.com/50420043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5