code review 50380043: gosshnew/ssh: don't block Wait on copying stdin

gosshnew/ssh: don't block Wait on copying stdin

The new TestRunCommandStdin test case would block
with the old code, as Wait blocks until the stdio
copy goroutines complete. To resolve this, I have
added a pipe between the user-specified stdin and
the stdin channel. The write end of the pipe is
closed prior to waiting for the copy goroutine's
completion.

Fixes #6088

[axw, 2014-01-10 05:39:10]

Hello agl@golang.org, dave@cheney.net, hanwen@google.com, jpsugar@google.com,
golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/gosshnew

[hanwen-google, 2014-01-10 08:32:36]

LGTM

[hanwen-google, 2014-01-10 08:36:05]

*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=f6edaf15031d
***

gosshnew/ssh: don't block Wait on copying stdin

The new TestRunCommandStdin test case would block
with the old code, as Wait blocks until the stdio
copy goroutines complete. To resolve this, I have
added a pipe between the user-specified stdin and
the stdin channel. The write end of the pipe is
closed prior to waiting for the copy goroutine's
completion.

Fixes issue 6088.

R=agl, dave, hanwen, jpsugar, golang-codereviews
CC=agl, dave, golang-codereviews, hanwen, jpsugar
https://codereview.appspot.com/50380043

Committer: Han-Wen Nienhuys <hanwen@google.com>

[hanwen-google, 2014-01-24 15:01:08]

can you close this issue?

[hanwen-google, 2014-01-24 15:01:59]

actually, it already disappeared from my dashboard. Strange.