Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2192)

Issue 50280043: Simplifying entrypoint.dart, and changed IO load. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by pajamallama
Modified:
10 years, 3 months ago
Reviewers:
tapted
CC:
chrome-apps-internsyd_google.com
Base URL:
https://github.com/tapted/bleeding_edge.git@compiling_to_js
Visibility:
Public.

Description

Simplifying entrypoint.dart, and changed IO load. Now *.load(PathRep) methods will return null on file not existing instead of throwing an error. R=tapted@chromium.org Committed: https://github.com/tapted/bleeding_edge/commit/b526326

Patch Set 1 #

Patch Set 2 : Fixing deleteEntry & symlink creation. #

Patch Set 3 : Fixed Link.load #

Total comments: 2

Patch Set 4 : Changing log message. #

Patch Set 5 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -57 lines) Patch
M dart/sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 2 3 1 chunk +17 lines, -23 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/io.dart View 1 5 chunks +17 lines, -21 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart View 1 2 3 4 5 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 6
pajamallama
10 years, 3 months ago (2014-01-09 23:18:41 UTC) #1
pajamallama
Fixed some bugs in this code (arising from the exception => return null change).
10 years, 3 months ago (2014-01-10 00:48:06 UTC) #2
pajamallama
Added another (very tiny) patch.. Soz!
10 years, 3 months ago (2014-01-10 01:03:38 UTC) #3
tapted
lgtm with a nit https://codereview.appspot.com/50280043/diff/60001/dart/sdk/lib/_internal/pub/lib/src/entrypoint.dart File dart/sdk/lib/_internal/pub/lib/src/entrypoint.dart (right): https://codereview.appspot.com/50280043/diff/60001/dart/sdk/lib/_internal/pub/lib/src/entrypoint.dart#newcode86 dart/sdk/lib/_internal/pub/lib/src/entrypoint.dart:86: log.fine("Deleting package directory for ${id.name} ...
10 years, 3 months ago (2014-01-10 02:20:55 UTC) #4
pajamallama
https://codereview.appspot.com/50280043/diff/60001/dart/sdk/lib/_internal/pub/lib/src/entrypoint.dart File dart/sdk/lib/_internal/pub/lib/src/entrypoint.dart (right): https://codereview.appspot.com/50280043/diff/60001/dart/sdk/lib/_internal/pub/lib/src/entrypoint.dart#newcode86 dart/sdk/lib/_internal/pub/lib/src/entrypoint.dart:86: log.fine("Deleting package directory for ${id.name} before get."); On 2014/01/10 ...
10 years, 3 months ago (2014-01-12 22:53:13 UTC) #5
pajamallama
10 years, 3 months ago (2014-01-13 00:24:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as rb526326 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b