Issue 50270044: code review 50270044: re2: fixes for darwin

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 50270044: code review 50270044: re2: fixes for darwin (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rsc

Modified:
11 years, 5 months ago

Reviewers:

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

re2: fixes for darwin Probably will break other things. Thanks to various issue reporters for suggestions. Fixes issue 59. Fixes issue 76. Fixes issue 77. Fixes issue 81. Fixes issue 87. Fixes issue 90. Fixes issue 92. Fixes issue 94.

Patch Set 1 #

Patch Set 2 : diff -r 08974aadd47a https://code.google.com/p/re2/ #

Patch Set 3 : diff -r 08974aadd47a https://code.google.com/p/re2/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -16 lines)			Patch
M	Makefile	View	1 2	2 chunks	+11 lines, -8 lines	0 comments	Download
M	libre2.symbols	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	libre2.symbols.darwin	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	re2/testing/re2_test.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	testinstall.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	util/util.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	util/valgrind.cc	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/re2/

11 years, 5 months ago (2014-01-10 01:49:09 UTC) #1

rsc

11 years, 5 months ago (2014-01-10 01:49:14 UTC) #2

*** Submitted as https://code.google.com/p/re2/source/detail?r=975db9909185 ***

re2: fixes for darwin

Probably will break other things.
Thanks to various issue reporters for suggestions.

Fixes issue 59.
Fixes issue 76.
Fixes issue 77.
Fixes issue 81.
Fixes issue 87.
Fixes issue 90.
Fixes issue 92.
Fixes issue 94.

R=rsc
CC=re2-dev
https://codereview.appspot.com/50270044

Expand All Messages | Collapse All Messages