Issue 50220044: parsing: constify re2 tables.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 50220044: parsing: constify re2 tables.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by ostap

Modified:
11 years, 3 months ago

Reviewers:
rsc

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

parsing: constify re2 tables. Helps for moving tables to .rodata segment. Useful on chrome for Android. http://code.google.com/p/chromium/issues/detail?id=249746 Also might help compiler optimisations.

Patch Set 1 #

Patch Set 2 : diff -r 29591379d23a https://re2.googlecode.com/hg #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+208 lines, -208 lines)			Patch
M	re2/make_perl_groups.pl	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	re2/make_unicode_casefold.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	re2/make_unicode_groups.py	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	re2/parse.cc	View	1	9 chunks	+12 lines, -12 lines	0 comments	Download
M	re2/perl_groups.cc	View	1	3 chunks	+21 lines, -21 lines	0 comments	Download
M	re2/unicode_groups.h	View	1	1 chunk	+8 lines, -8 lines	0 comments	Download
M	re2/unicode_groups.cc	View	1	76 chunks	+160 lines, -160 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

11 years, 3 months ago (2014-01-10 00:49:08 UTC) #3

*** Submitted as https://code.google.com/p/re2/source/detail?r=08974aadd47a ***

re2: make tables const

Helps for moving tables to .rodata segment. Useful on chrome for Android.
http://code.google.com/p/chromium/issues/detail?id=249746
Also might help compiler optimisations.

R=rsc
CC=re2-dev
https://codereview.appspot.com/50220044

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages