Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3839)

Issue 50140045: code review 50140045: fmt: make benchmarks parallel (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by dvyukov
Modified:
10 years, 3 months ago
Reviewers:
bradfitz
CC:
golang-codereviews
Visibility:
Public.

Description

fmt: make benchmarks parallel This seems to be the best target to benchmark sync.Pool changes. This is resend of cl/49910043 which was LGTMed by TBR=bradfitz

Patch Set 1 #

Patch Set 2 : diff -r 9d797d0b899b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 9d797d0b899b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 9d797d0b899b https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M src/pkg/fmt/fmt_test.go View 1 2 chunks +36 lines, -15 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 3 months ago (2014-01-10 09:41:26 UTC) #1
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=63dc9bf51514 *** fmt: make benchmarks parallel This seems to be the best ...
10 years, 3 months ago (2014-01-10 09:51:32 UTC) #2
bradfitz
10 years, 3 months ago (2014-01-10 17:55:05 UTC) #3
Message was sent while issue was closed.
LGTM again
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b