Add the environment name to the hooks context.

Add the environment name to the hooks context.

Expose the human friendly environment name to the 
hooks through the JUJU_ENV_NAME environment variable.

This is required e.g. by the GUI in order to give to the user
a hint about where to find the password to log in.

https://code.launchpad.net/~frankban/juju-core/env-name-in-context/+merge/204450

(do not edit description out of merge proposal)

[frankban, 2014-02-03 10:58:42]

Please take a look.

[dimitern, 2014-02-03 11:20:12]

LGTM with a few suggestions below. Nice!

https://codereview.appspot.com/50090044/diff/1/state/api/params/internal.go
File state/api/params/internal.go (right):

https://codereview.appspot.com/50090044/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:115: // environment.
// EnvironmentResult holds the result of an API call returning a name and UUID
for an environment ?

Also s/CurrentEnvironmentResult/EnvironmentResult/ ?

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/environ.go
File state/api/uniter/environ.go (left):

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/environ.go#ol...
state/api/uniter/environ.go:23: // TODO(dimitern): 2013-09-06 bug 1221834
Can you update the bug to exclude Environ.UUID() from the list, because with
this change I think we can consider it cached.

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/environ.go
File state/api/uniter/environ.go (right):

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/environ.go#ne...
state/api/uniter/environ.go:9: // Environment represents the name and the unique
identifier of an environment.
No need to change this comment I think - see other examples in api/uniter.

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/uniter.go
File state/api/uniter/uniter.go (right):

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/uniter.go#new...
state/api/uniter/uniter.go:164: if err != nil {
you need to check result.Error as well, in addition to checking err - see
APIAddresses below.

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/uniter.go#new...
state/api/uniter/uniter.go:173: func (st *State) environment1dot16()
(*Environment, error) {
// environment1dot16 requests just the UUID of the current environment, when
using an older apiserver that does not support CurrentEnvironment API call. ?

[frankban, 2014-02-03 12:04:46]

Please take a look.

https://codereview.appspot.com/50090044/diff/1/state/api/params/internal.go
File state/api/params/internal.go (right):

https://codereview.appspot.com/50090044/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:115: // environment.
On 2014/02/03 11:20:12, dimitern wrote:
> // EnvironmentResult holds the result of an API call returning a name and UUID
> for an environment ?
> 
> Also s/CurrentEnvironmentResult/EnvironmentResult/ ?

Done.

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/environ.go
File state/api/uniter/environ.go (left):

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/environ.go#ol...
state/api/uniter/environ.go:23: // TODO(dimitern): 2013-09-06 bug 1221834
On 2014/02/03 11:20:12, dimitern wrote:
> Can you update the bug to exclude Environ.UUID() from the list, because with
> this change I think we can consider it cached.

Done.

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/environ.go
File state/api/uniter/environ.go (right):

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/environ.go#ne...
state/api/uniter/environ.go:9: // Environment represents the name and the unique
identifier of an environment.
On 2014/02/03 11:20:12, dimitern wrote:
> No need to change this comment I think - see other examples in api/uniter.

Done.

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/uniter.go
File state/api/uniter/uniter.go (right):

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/uniter.go#new...
state/api/uniter/uniter.go:164: if err != nil {
On 2014/02/03 11:20:12, dimitern wrote:
> you need to check result.Error as well, in addition to checking err - see
> APIAddresses below.

Done.

https://codereview.appspot.com/50090044/diff/1/state/api/uniter/uniter.go#new...
state/api/uniter/uniter.go:173: func (st *State) environment1dot16()
(*Environment, error) {
On 2014/02/03 11:20:12, dimitern wrote:
> // environment1dot16 requests just the UUID of the current environment, when
> using an older apiserver that does not support CurrentEnvironment API call. ?

Done.

[frankban, 2014-02-03 12:06:54]

Thank you!