Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(198)

Issue 50060047: code review 50060047: cmd/gc: change compile error to "use of package %S with... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by btracey
Modified:
11 years, 1 month ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

cmd/gc: change compile error to "use of package %S without selector" At present, when a package identifier is used outside of a selector expression, gc gives the error "use of package %S outside selector". However, in the selector expression x.f, the spec defines f as the selector. This change makes the error clearer. Fixes issue 7133.

Patch Set 1 #

Patch Set 2 : diff -r 9e0b2af78b5c https://code.google.com/p/go #

Patch Set 3 : diff -r 9e0b2af78b5c https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/typecheck.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
btracey
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2014-02-10 19:27:25 UTC) #1
btracey
Added CC On Monday, February 10, 2014 11:27:25 AM UTC-8, tracey....@gmail.com wrote: > Reviewers: golang-codereviews, ...
11 years, 4 months ago (2014-02-10 22:10:06 UTC) #2
rsc
LGTM
11 years, 4 months ago (2014-02-11 01:25:36 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=72ef9cff4fa9 *** cmd/gc: change compile error to "use of package %S without ...
11 years, 4 months ago (2014-02-11 01:27:36 UTC) #4
gobot
11 years, 4 months ago (2014-02-11 01:56:15 UTC) #5
This CL appears to have broken the darwin-amd64 builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b