Issue 49940044: Add substrate configuration to juju-test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49940044: Add substrate configuration to juju-test

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by Marco Ceppi

Modified:
10 years, 4 months ago

Reviewers:
benjamin.saller, mp+201094

Visibility:
Public.

Description

Add substrate configuration to juju-test https://code.launchpad.net/~marcoceppi/charm-tools/substrate-cfg/+merge/201094 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add substrate configuration to juju-test #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -37 lines)			Patch
M	.bzrignore	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmtools/bundles.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	charmtools/generate.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	charmtools/test.py	View	10 chunks	+109 lines, -26 lines	0 comments	Download
M	charmtools/update.py	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/test_juju_test.py	View	10 chunks	+12 lines, -9 lines	0 comments	Download
A	tests/test_substrates.py	View	1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM Thanks for including my suggestions (and making the actual integration work). The changes to ...

10 years, 4 months ago (2014-01-09 20:25:48 UTC) #2

Marco Ceppi

10 years, 4 months ago (2014-01-09 21:42:33 UTC) #3

*** Submitted:

Add substrate configuration to juju-test

R=benjamin.saller
CC=
https://codereview.appspot.com/49940044

Expand All Messages | Collapse All Messages