code review 49930051: encoding/json: fix test failure

encoding/json: fix test failure
$ go test -cpu=1,1,1,1,1,1,1,1,1 encoding/json
--- FAIL: TestIndentBig (0.00 seconds)
        scanner_test.go:131: Indent(jsonBig) did not get bigger
On 4-th run initBig generates an empty array.

[dvyukov, 2014-02-06 08:41:39]

Hello golang-dev@googlegroups.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[bradfitz, 2014-02-06 22:49:28]

LGTM

Yay tests with rand.



On Thu, Feb 6, 2014 at 12:41 AM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev,
>
> Message:
> Hello golang-dev@googlegroups.com (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> encoding/json: fix test failure
> $ go test -cpu=1,1,1,1,1,1,1,1,1 encoding/json
> --- FAIL: TestIndentBig (0.00 seconds)
>         scanner_test.go:131: Indent(jsonBig) did not get bigger
> On 4-th run initBig generates an empty array.
>
> Please review this at https://codereview.appspot.com/49930051/
>
> Affected files (+9, -13 lines):
>   M src/pkg/encoding/json/scanner_test.go
>
>
> Index: src/pkg/encoding/json/scanner_test.go
> ===================================================================
> --- a/src/pkg/encoding/json/scanner_test.go
> +++ b/src/pkg/encoding/json/scanner_test.go
> @@ -239,23 +239,16 @@
>
>  var jsonBig []byte
>
> -const (
> -       big   = 10000
> -       small = 100
> -)
> -
>  func initBig() {
> -       n := big
> +       n := 10000
>         if testing.Short() {
> -               n = small
> +               n = 100
>         }
> -       if len(jsonBig) != n {
> -               b, err := Marshal(genValue(n))
> -               if err != nil {
> -                       panic(err)
> -               }
> -               jsonBig = b
> +       b, err := Marshal(genValue(n))
> +       if err != nil {
> +               panic(err)
>         }
> +       jsonBig = b
>  }
>
>  func genValue(n int) interface{} {
> @@ -296,6 +289,9 @@
>         if f > n {
>                 f = n
>         }
> +       if f < 1 {
> +               f = 1
> +       }
>         x := make([]interface{}, f)
>         for i := range x {
>                 x[i] = genValue(((i+1)*n)/f - (i*n)/f)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[gobot, 2014-02-12 16:46:28]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[dvyukov, 2014-02-12 17:51:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=d2cd0d13a008 ***

encoding/json: fix test failure
$ go test -cpu=1,1,1,1,1,1,1,1,1 encoding/json
--- FAIL: TestIndentBig (0.00 seconds)
        scanner_test.go:131: Indent(jsonBig) did not get bigger
On 4-th run initBig generates an empty array.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/49930051