Issue 49880043: Fix a Choice parsing bug uncovered by invalid IP addresses, add test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49880043: Fix a Choice parsing bug uncovered by invalid IP addresses, add test

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by ekasper

Modified:
10 years, 3 months ago

Reviewers:
Eran, Ben Laurie (Google)

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Description

Fix a Choice parsing bug uncovered by invalid IP addresses, add test

Patch Set 2 : reupload #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -2 lines)			Patch
M	src/python/ct/crypto/asn1/types.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/python/ct/crypto/asn1/x509_name.py	View	2 chunks	+3 lines, -1 line	2 comments	Download
M	src/python/ct/crypto/cert_test.py	View	2 chunks	+11 lines, -0 lines	0 comments	Download
A	src/python/ct/crypto/testdata/invalid_ip.pem	View	1 chunk	+108 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ekasper

The bug: the "strict" keyword arg was dropped inside the Choice decoder, causing the invalid ...

10 years, 3 months ago (2014-01-09 15:47:20 UTC) #1

Ben Laurie (Google)

LGTM https://codereview.appspot.com/49880043/diff/20001/src/python/ct/crypto/asn1/x509_name.py File src/python/ct/crypto/asn1/x509_name.py (right): https://codereview.appspot.com/49880043/diff/20001/src/python/ct/crypto/asn1/x509_name.py#newcode187 src/python/ct/crypto/asn1/x509_name.py:187: print_labels = True # Print component type. What ...

10 years, 3 months ago (2014-01-14 19:57:11 UTC) #3

ekasper

10 years, 3 months ago (2014-01-15 16:05:09 UTC) #4

https://codereview.appspot.com/49880043/diff/20001/src/python/ct/crypto/asn1/...
File src/python/ct/crypto/asn1/x509_name.py (right):

https://codereview.appspot.com/49880043/diff/20001/src/python/ct/crypto/asn1/...
src/python/ct/crypto/asn1/x509_name.py:187: print_labels = True  # Print
component type.
On 2014/01/14 19:57:11, Ben Laurie (Google) wrote:
> What does this do?

Prints the component name when prettyprinting, e.g.,

dnsName: www.google.com

I just set those subjectively to what looks like the right amount of detail when
printing a certificate...

Expand All Messages | Collapse All Messages