Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(219)

Issue 4981052: changes in chord names formatting (1503, 1572) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by janek
Modified:
7 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

http://code.google.com/p/lilypond/issues/detail?id=1503 http://code.google.com/p/lilypond/issues/detail?id=1572 1503 - Allow choice of prefix for chord modifiers. This was previously "add", e.g. "Cmaj7 add6add9", but this results in too much clutter and is rarely used. Issue 1503 - Allow choice of minor chord modifier. For example, often it is preferred to use a hyphen instead of "m". This can now be achieved via: \set minorChordModifier = \markup { "-" } add chordInversionSeparator Issue 1572 and issue 1503 - Allow choice of chord modifier separator independently of chord inversion separator, since conventionally the latter is always a slash (hence the term "slash chords"), whereas the former seldom involves slashes. Issue 1503 - Recognise Lydian chords enlarge half-diminished slashed circle symbol

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M ly/chord-modifiers-init.ly View 1 chunk +2 lines, -1 line 1 comment Download
M ly/engraver-init.ly View 1 chunk +4 lines, -1 line 0 comments Download
M scm/chord-ignatzek-names.scm View 3 chunks +6 lines, -3 lines 2 comments Download
M scm/define-context-properties.scm View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9
janek
Patches from Adam Spiers.
7 years, 9 months ago (2011-09-10 20:59:23 UTC) #1
janek
LGTM
7 years, 9 months ago (2011-09-10 21:00:14 UTC) #2
Trevor Daniels
LGTM AFAICT, but I am not familiar with chord notation. Presumably there should be some ...
7 years, 9 months ago (2011-09-10 21:49:26 UTC) #3
pkx166h
Passes make test but fails reg test check. See: http://code.google.com/p/lilypond/issues/detail?id=1572#c7 for more information James
7 years, 9 months ago (2011-09-11 07:16:25 UTC) #4
adam.spiers
I have finally figured out how to reproduce these regressions, and am working on a ...
7 years, 7 months ago (2011-11-01 16:40:47 UTC) #5
adam.spiers
I think I am now finished. The new patch series is available at https://github.com/aspiers/lilypond/commits/jazz IMHO ...
7 years, 7 months ago (2011-11-02 17:58:51 UTC) #6
adam.spiers
I've done a corresponding patch for changes.tely but I don't have permissions to upload it ...
7 years, 7 months ago (2011-11-06 15:52:15 UTC) #7
Graham Percival
On Sun, Nov 06, 2011 at 03:52:15PM +0000, adam.spiers@gmail.com wrote: > I've done a corresponding ...
7 years, 7 months ago (2011-11-07 00:15:48 UTC) #8
adam.spiers
7 years, 7 months ago (2011-11-07 11:13:09 UTC) #9
On 2011/11/07 00:15:48, Graham Percival wrote:
> On Sun, Nov 06, 2011 at 03:52:15PM +0000, mailto:adam.spiers@gmail.com wrote:
> > I've done a corresponding patch for changes.tely but I don't have
> > permissions to upload it to this issue
> 
> that's because Janek uploaded the original issue.  Could you just
> make a new one?  just ignore the old codereview issue.
> 
> Uploading a new patch with git-cl, and associate it with issue
> tracker 1503 or 1572.
> 
> - Graham

Whoops, I forgot that Carl already created a separate issue for the new version
of this patch series:

http://codereview.appspot.com/5320074

So this one (4981052) should be ignored entirely now, and closed/deleted when
Janek gets back.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b