Issue 49800043: Fix VisibleString tag, add test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by ekasper

Modified:
10 years, 3 months ago

Reviewers:
Eran, Ben Laurie (Google)

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

Fix VisibleString tag, add test

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -3 lines)			Patch
M	src/python/ct/crypto/asn1/types.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/python/ct/crypto/asn1/x509_extension.py	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/python/ct/crypto/cert.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/python/ct/crypto/cert_test.py	View	2 chunks	+22 lines, -0 lines	0 comments	Download
A	src/python/ct/crypto/testdata/user_notice.pem	View	1 chunk	+99 lines, -0 lines	0 comments	Download

Total messages: 3

ekasper

I typoed the tag in https://codereview.appspot.com/47920044/

10 years, 3 months ago (2014-01-09 13:35:24 UTC) #1

ekasper

Eran, would you mind taking this? I think Ben's now gone for a while.

10 years, 3 months ago (2014-01-14 12:16:03 UTC) #2

LGTM