Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11288)

Issue 4975060: code review 4975060: net, syscall: implement SetsockoptIPMReq(), move to win...

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by Paul Lalonde
Modified:
12 years, 7 months ago
Reviewers:
brainman, rsc
CC:
rsc, brainman, nigeltao, golang-dev
Visibility:
Public.

Description

Windows: net, syscall: implement SetsockoptIPMReq(), move to winsock v2.2 for multicast support. I don't know the protocol regarding the zsyscall files which appear to be hand-generated, so I've re-done them and added them to the change.

Patch Set 1 #

Patch Set 2 : diff -r c9da4512c385 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -49 lines) Patch
M src/pkg/net/fd_windows.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 4 chunks +20 lines, -18 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 chunks +15 lines, -15 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_amd64.go View 1 2 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 6
Paul Lalonde
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 7 months ago (2011-09-07 15:44:15 UTC) #1
rsc
LGTM Leaving for Alex.
12 years, 7 months ago (2011-09-07 18:33:44 UTC) #2
brainman
LGTM. Please compete http://golang.org/doc/contribute.html#copyright, and I will submit. Thank you. Alex
12 years, 7 months ago (2011-09-08 04:28:49 UTC) #3
paul.a.lalonde_gmail.com
I submitted the individual copyright holder form some days (2 weeks?) ago; I can do ...
12 years, 7 months ago (2011-09-08 06:12:57 UTC) #4
nigeltao
On 8 September 2011 16:19, Paul Lalonde <paul.a.lalonde@gmail.com> wrote: > I submitted the individual copyright ...
12 years, 7 months ago (2011-09-08 06:26:47 UTC) #5
nigeltao
12 years, 7 months ago (2011-09-08 06:32:46 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=56c50c2e16e5 ***

Windows: net, syscall: implement SetsockoptIPMReq(), move to winsock v2.2 for
multicast support.
I don't know the protocol regarding the zsyscall files which appear to
be hand-generated, so I've re-done them and added them to the change.

R=rsc, alex.brainman, nigeltao
CC=golang-dev
http://codereview.appspot.com/4975060

Committer: Nigel Tao <nigeltao@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b