Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1500)

Issue 4975048: Added LateParsed property to attributes in TableGen code.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by delesley
Modified:
8 years, 2 months ago
Reviewers:
chandlerc, supertri
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Incorporated comments from supertri. #

Total comments: 2

Patch Set 3 : Minor style fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M utils/TableGen/ClangAttrEmitter.h View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M utils/TableGen/ClangAttrEmitter.cpp View 1 1 chunk +23 lines, -0 lines 0 comments Download
M utils/TableGen/TableGen.cpp View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4
supertri
http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter.cpp File utils/TableGen/ClangAttrEmitter.cpp (right): http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter.cpp#newcode774 utils/TableGen/ClangAttrEmitter.cpp:774: std::vector<StringRef> Spellings = getValueAsListOfStrings(Attr, "Spellings"); Over 80 characters. http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter.cpp#newcode776 ...
8 years, 2 months ago (2011-09-01 18:35:41 UTC) #1
delesley
http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter.cpp File utils/TableGen/ClangAttrEmitter.cpp (right): http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter.cpp#newcode774 utils/TableGen/ClangAttrEmitter.cpp:774: std::vector<StringRef> Spellings = getValueAsListOfStrings(Attr, "Spellings"); On 2011/09/01 18:35:41, supertri ...
8 years, 2 months ago (2011-09-01 20:26:08 UTC) #2
chandlerc
http://codereview.appspot.com/4975048/diff/4001/utils/TableGen/ClangAttrEmitter.h File utils/TableGen/ClangAttrEmitter.h (right): http://codereview.appspot.com/4975048/diff/4001/utils/TableGen/ClangAttrEmitter.h#newcode107 utils/TableGen/ClangAttrEmitter.h:107: {} For reasons that baffle me, all of the ...
8 years, 2 months ago (2011-09-01 22:11:10 UTC) #3
delesley
8 years, 2 months ago (2011-09-02 18:23:40 UTC) #4
http://codereview.appspot.com/4975048/diff/4001/utils/TableGen/ClangAttrEmitt...
File utils/TableGen/ClangAttrEmitter.h (right):

http://codereview.appspot.com/4975048/diff/4001/utils/TableGen/ClangAttrEmitt...
utils/TableGen/ClangAttrEmitter.h:107: {}
On 2011/09/01 22:11:10, chandlerc wrote:
> For reasons that baffle me, all of the previous entries here line up the {
with
> the : on the previous line... might as well be consistent.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b