Issue 49720043: code review 49720043: liblink: adjust format verbs to avoid collisions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49720043: code review 49720043: liblink: adjust format verbs to avoid collisions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by ality

Modified:
11 years, 6 months ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

liblink: adjust format verbs to avoid collisions The %S and %N format verbs are used by cmd/gc to represent Sym and Node structures, respectively. In liblink, these two verbs are used only by the %D format routine and never referenced externally. This change will allow us to delete the duplicated code for the %A, %D, %P, and %R format routines in both the compiler and linker.

Patch Set 1 #

Patch Set 2 : diff -r db95cbe91420 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 884801fb67af https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9e5ec71fa488 https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -23 lines)			Patch
M	src/liblink/list5.c	View	1	6 chunks	+15 lines, -15 lines	0 comments	Download
M	src/liblink/list6.c	View	1	4 chunks	+17 lines, -4 lines	0 comments	Download
M	src/liblink/list8.c	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2014-01-09 11:36:28 UTC) #1

rsc

LGTM I think your %$ is %Z in the Go compiler but keep it at ...

11 years, 6 months ago (2014-01-09 21:19:55 UTC) #2

ality

11 years, 6 months ago (2014-01-10 03:02:24 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=72f6ec05c6ca ***

liblink: adjust format verbs to avoid collisions

The %S and %N format verbs are used by cmd/gc to
represent Sym and Node structures, respectively.

In liblink, these two verbs are used only by the %D
format routine and never referenced externally.

This change will allow us to delete the duplicated
code for the %A, %D, %P, and %R format routines in
both the compiler and linker.

R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/49720043

Expand All Messages | Collapse All Messages