Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(187)

Issue 49710050: code review 49710050: net: add plan9 to TestDialTimeout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by jas
Modified:
11 years, 6 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz, 0intro, rsc
Visibility:
Public.

Description

net: add plan9 to TestDialTimeout === RUN TestDialTimeout --- PASS: TestDialTimeout (0.21 seconds)

Patch Set 1 #

Patch Set 2 : diff -r ca4b7db0560c https://code.google.com/p/go/ #

Patch Set 3 : diff -r ca4b7db0560c https://code.google.com/p/go/ #

Patch Set 4 : diff -r ca4b7db0560c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/net/dial_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
jas
Hello golang-codereviews@googlegroups.com (cc: 0intro@gmail.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2014-01-11 16:50:53 UTC) #1
bradfitz
LGTM On Jan 11, 2014 8:50 AM, <jas@corpus-callosum.com> wrote: > Reviewers: golang-codereviews, > > Message: ...
11 years, 6 months ago (2014-01-11 16:51:20 UTC) #2
0intro
Works for me.
11 years, 6 months ago (2014-01-11 17:57:28 UTC) #3
0intro
11 years, 6 months ago (2014-01-11 17:58:12 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=f6751073ac50 ***

net: add plan9 to TestDialTimeout
     === RUN TestDialTimeout
     --- PASS: TestDialTimeout (0.21 seconds)

R=golang-codereviews, bradfitz, 0intro
CC=golang-codereviews, rsc
https://codereview.appspot.com/49710050

Committer: David du Colombier <0intro@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b