Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4685)

Issue 49700045: Add support for debug mode in getting charm icons.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by bac
Modified:
10 years, 2 months ago
Reviewers:
mp+204986
Visibility:
Public.

Description

Add support for debug mode in getting charm icons. Normally a non-promulgated charm will get the generic icon, even if it has its own icon. Adding a '?debug' querystring will cause it to return the actual icon. Landing this change for Rick Harding. * Changed debug default value to False from None. * Added a test for a non-promulgated charm that does have an icon but no debug querystring. https://code.launchpad.net/~bac/charmworld/rick-charm-icons-debug/+merge/204986 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add support for debug mode in getting charm icons. #

Patch Set 3 : Add support for debug mode in getting charm icons. #

Patch Set 4 : Add support for debug mode in getting charm icons. #

Patch Set 5 : Add support for debug mode in getting charm icons. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/views/api/__init__.py View 3 chunks +4 lines, -4 lines 0 comments Download
M charmworld/views/tests/test_api.py View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2
bac
Please take a look.
10 years, 2 months ago (2014-02-05 15:56:47 UTC) #1
bac
10 years, 2 months ago (2014-02-05 15:57:23 UTC) #2
LGTM self-review
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b