Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 4964078: code review 4964078: crypto/bcrypt: new package (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by jmhodges
Modified:
9 years, 2 months ago
Reviewers:
CC:
bradfitz, agl1, rsc, dchest, golang-dev
Visibility:
Public.

Description

crypto/bcrypt: new package A port of Provos and Mazières's adapative hashing algorithm. See http://www.usenix.org/events/usenix99/provos/provos_html/node1.html

Patch Set 1 #

Patch Set 2 : diff -r e54178c07218 https://go.googlecode.com/hg/ #

Total comments: 15

Patch Set 3 : diff -r e54178c07218 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e54178c07218 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r d21944c38c39 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 6 : diff -r d21944c38c39 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 7 : diff -r d21944c38c39 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r d21944c38c39 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -0 lines) Patch
M src/pkg/Makefile View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A src/pkg/crypto/bcrypt/Makefile View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A src/pkg/crypto/bcrypt/base64.go View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
A src/pkg/crypto/bcrypt/bcrypt.go View 1 2 3 4 5 6 7 1 chunk +282 lines, -0 lines 0 comments Download
A src/pkg/crypto/bcrypt/bcrypt_test.go View 1 2 3 4 5 6 7 1 chunk +191 lines, -0 lines 0 comments Download

Messages

Total messages: 20
jmhodges
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 2 months ago (2011-09-12 09:12:37 UTC) #1
jmhodges
I also have a nice performance improvement for blowfish.encryptBlock and decryptBlock, but I'd like to ...
9 years, 2 months ago (2011-09-12 09:24:56 UTC) #2
agl1
I'm ok with the interface changes to crypto/blowfish. http://codereview.appspot.com/4964078/diff/2001/src/pkg/crypto/bcrypt/Makefile File src/pkg/crypto/bcrypt/Makefile (right): http://codereview.appspot.com/4964078/diff/2001/src/pkg/crypto/bcrypt/Makefile#newcode1 src/pkg/crypto/bcrypt/Makefile:1: # ...
9 years, 2 months ago (2011-09-12 14:24:03 UTC) #3
rsc
Please split the blowfish changes into a separate CL. Thanks. http://codereview.appspot.com/4964078/diff/2001/src/pkg/crypto/blowfish/block.go File src/pkg/crypto/blowfish/block.go (right): http://codereview.appspot.com/4964078/diff/2001/src/pkg/crypto/blowfish/block.go#newcode8 ...
9 years, 2 months ago (2011-09-12 16:46:47 UTC) #4
jmhodges
On 2011/09/12 16:46:47, rsc wrote: > Please split the blowfish changes into a separate CL. ...
9 years, 2 months ago (2011-09-14 02:39:57 UTC) #5
jmhodges
On 2011/09/12 14:24:03, agl1 wrote: > I'm ok with the interface changes to crypto/blowfish. > ...
9 years, 2 months ago (2011-09-14 06:55:30 UTC) #6
jmhodges
Hello bradfitz@golang.org, agl@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 2 months ago (2011-09-14 08:39:38 UTC) #7
jmhodges
Hello bradfitz@golang.org, agl@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 2 months ago (2011-09-16 01:19:40 UTC) #8
agl1
I think this is basically there minus nits. I'll land the next revision unless anyone ...
9 years, 2 months ago (2011-09-16 20:43:47 UTC) #9
jmhodges
On 2011/09/16 20:43:47, agl1 wrote: > I think this is basically there minus nits. I'll ...
9 years, 2 months ago (2011-09-16 21:14:22 UTC) #10
jmhodges
Hello bradfitz@golang.org, agl@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 2 months ago (2011-09-16 21:15:45 UTC) #11
dchest
http://codereview.appspot.com/4964078/diff/26001/src/pkg/crypto/bcrypt/bcrypt.go File src/pkg/crypto/bcrypt/bcrypt.go (right): http://codereview.appspot.com/4964078/diff/26001/src/pkg/crypto/bcrypt/bcrypt.go#newcode132 src/pkg/crypto/bcrypt/bcrypt.go:132: io.ReadFull(rand.Reader, unencodedSalt) Missing error check here.
9 years, 2 months ago (2011-09-16 23:27:52 UTC) #12
dchest
http://codereview.appspot.com/4964078/diff/26001/src/pkg/crypto/bcrypt/bcrypt.go File src/pkg/crypto/bcrypt/bcrypt.go (right): http://codereview.appspot.com/4964078/diff/26001/src/pkg/crypto/bcrypt/bcrypt.go#newcode145 src/pkg/crypto/bcrypt/bcrypt.go:145: n, err := p.decodeVersion(hashedSecret) Before doing p.decodeVersion/p.decodeCost shouldn't there ...
9 years, 2 months ago (2011-09-16 23:53:44 UTC) #13
jmhodges
Hello bradfitz@golang.org, agl@golang.org, rsc@golang.org, dchest@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 2 months ago (2011-09-17 00:50:49 UTC) #14
jmhodges
Hello bradfitz@golang.org, agl@golang.org, rsc@golang.org, dchest@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 2 months ago (2011-09-17 00:53:32 UTC) #15
jmhodges
On 2011/09/16 23:53:44, dchest wrote: > http://codereview.appspot.com/4964078/diff/26001/src/pkg/crypto/bcrypt/bcrypt.go > File src/pkg/crypto/bcrypt/bcrypt.go (right): > > http://codereview.appspot.com/4964078/diff/26001/src/pkg/crypto/bcrypt/bcrypt.go#newcode145 > ...
9 years, 2 months ago (2011-09-17 00:53:44 UTC) #16
jmhodges
On 2011/09/16 23:27:52, dchest wrote: > http://codereview.appspot.com/4964078/diff/26001/src/pkg/crypto/bcrypt/bcrypt.go > File src/pkg/crypto/bcrypt/bcrypt.go (right): > > http://codereview.appspot.com/4964078/diff/26001/src/pkg/crypto/bcrypt/bcrypt.go#newcode132 > ...
9 years, 2 months ago (2011-09-17 00:53:58 UTC) #17
agl1
*** Submitted as http://code.google.com/p/go/source/detail?r=d8c1aeda704a *** crypto/bcrypt: new package A port of Provos and Mazières's adapative ...
9 years, 2 months ago (2011-09-19 14:29:13 UTC) #18
agl1
On Mon, Sep 19, 2011 at 10:29 AM, <agl@golang.org> wrote: > *** Submitted as > ...
9 years, 2 months ago (2011-09-19 14:30:30 UTC) #19
jmhodges
9 years, 2 months ago (2011-09-19 16:46:15 UTC) #20
SGTM.

On Mon, Sep 19, 2011 at 7:30 AM, Adam Langley <agl@golang.org> wrote:
> before landing:
>
> I removed "Works" from the end of one of the test names
>
> I made TestCost not run in short mode because it was taking > 3
> seconds on my workstation. That would probably have been a problem on
> slower machines.
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b