Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(841)

Issue 5013043: code review 5013043: crypto/blowfish: exposing the blowfish key schedule (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by jmhodges
Modified:
12 years, 6 months ago
Reviewers:
CC:
bradfitz, agl, rsc, agl1, golang-dev
Visibility:
Public.

Description

crypto/blowfish: exposing the blowfish key schedule Mostly useful for the coming crypto/bcrypt package

Patch Set 1 #

Patch Set 2 : diff -r e54178c07218 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e54178c07218 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : code review 5013043: crypto/blowfish: exposing the blowfish key schedule #

Patch Set 5 : code review 5013043: crypto/blowfish: exposing the blowfish key schedule #

Patch Set 6 : code review 5013043: crypto/blowfish: exposing the blowfish key schedule #

Patch Set 7 : diff -r d21944c38c39 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 8 : diff -r d21944c38c39 https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -8 lines) Patch
M src/pkg/crypto/blowfish/block.go View 1 2 3 4 5 6 7 2 chunks +98 lines, -7 lines 0 comments Download
M src/pkg/crypto/blowfish/blowfish_test.go View 1 2 3 4 5 6 1 chunk +18 lines, -0 lines 1 comment Download
M src/pkg/crypto/blowfish/cipher.go View 1 2 3 4 5 6 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 9
jmhodges
Hello bradfitz@golang.org (cc: agl@golang.org, golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 6 months ago (2011-09-14 02:39:05 UTC) #1
agl
http://codereview.appspot.com/5013043/diff/4001/src/pkg/crypto/blowfish/block.go File src/pkg/crypto/blowfish/block.go (right): http://codereview.appspot.com/5013043/diff/4001/src/pkg/crypto/blowfish/block.go#newcode12 src/pkg/crypto/blowfish/block.go:12: func ExpandKey(key []byte, c *Cipher) { Looks like this ...
12 years, 6 months ago (2011-09-14 18:53:37 UTC) #2
jmhodges
On 2011/09/14 18:53:37, agl wrote: > http://codereview.appspot.com/5013043/diff/4001/src/pkg/crypto/blowfish/block.go > File src/pkg/crypto/blowfish/block.go (right): > > http://codereview.appspot.com/5013043/diff/4001/src/pkg/crypto/blowfish/block.go#newcode12 > ...
12 years, 6 months ago (2011-09-15 10:37:39 UTC) #3
jmhodges
Hello bradfitz@golang.org, agl@chromium.org (cc: agl@golang.org, golang-dev@googlegroups.com, rsc@golang.org), Please take another look.
12 years, 6 months ago (2011-09-15 10:51:04 UTC) #4
rsc
Some documentation nits; otherwise looks good. http://codereview.appspot.com/5013043/diff/8003/src/pkg/crypto/blowfish/block.go File src/pkg/crypto/blowfish/block.go (right): http://codereview.appspot.com/5013043/diff/8003/src/pkg/crypto/blowfish/block.go#newcode10 src/pkg/crypto/blowfish/block.go:10: // by the ...
12 years, 6 months ago (2011-09-15 15:23:55 UTC) #5
jmhodges
Hello bradfitz@golang.org, agl@chromium.org, rsc@golang.org (cc: agl@golang.org, golang-dev@googlegroups.com), Please take another look.
12 years, 6 months ago (2011-09-16 00:57:32 UTC) #6
agl1
LGTM. Will land tomorrow. http://codereview.appspot.com/5013043/diff/13002/src/pkg/crypto/blowfish/blowfish_test.go File src/pkg/crypto/blowfish/blowfish_test.go (right): http://codereview.appspot.com/5013043/diff/13002/src/pkg/crypto/blowfish/blowfish_test.go#newcode195 src/pkg/crypto/blowfish/blowfish_test.go:195: key := []byte{} var key ...
12 years, 6 months ago (2011-09-16 20:45:27 UTC) #7
jmhodges
Thank you. On Fri, Sep 16, 2011 at 1:45 PM, <agl@golang.org> wrote: > LGTM. Will ...
12 years, 6 months ago (2011-09-16 20:51:20 UTC) #8
agl1
12 years, 6 months ago (2011-09-19 14:21:48 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=29a09c16bc16 ***

    crypto/blowfish: exposing the blowfish key schedule

Mostly useful for the coming crypto/bcrypt package

R=bradfitz, agl, rsc, agl
CC=golang-dev
http://codereview.appspot.com/5013043

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b