Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(639)

Issue 4963058: ipaddr-py: Support packed bytes on Python 2.x

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by pmarks
Modified:
7 years, 6 months ago
Reviewers:
Peter Moody
CC:
ipaddr-py-dev_googlegroups.com
Base URL:
http://ipaddr-py.googlecode.com/svn/trunk/
Visibility:
Public.

Description

- Provide 'Bytes', a subclass of str which can be used to indicate packed bytes on Python 2. - When constructing an IPAddress from packed bytes, do not fall back to str if the length is wrong. - Delete _BaseIP.__init__, and its redundant check for '/'. The IP parsers already recognize this as invalid input.

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : simplify IPNetwork constructors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -79 lines) Patch
M ipaddr.py View 1 2 10 chunks +43 lines, -57 lines 0 comments Download
M ipaddr_test.py View 1 3 chunks +23 lines, -22 lines 0 comments Download

Messages

Total messages: 3
pmarks
10 years, 3 months ago (2011-09-07 21:51:13 UTC) #1
pmarks
This code is probably drifting out of sync with the trunk by now, but could ...
10 years ago (2011-11-22 02:03:06 UTC) #2
Peter Moody
10 years ago (2011-11-24 20:58:56 UTC) #3
LGTM.

On 2011/11/22 02:03:06, pmarks wrote:
> This code is probably drifting out of sync with the trunk by now, but could
you
> let me know if you think it's worth updating?

ipaddr hasn't gotten much attention in the last couple of months, so this patch
applies cleanly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b