Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 49580044: code review 49580044: runtime: if traceback sees a breakpoint, don't change the PC (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by iant
Modified:
5 years, 9 months ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, dvyukov, rsc
Visibility:
Public.

Description

runtime: if traceback sees a breakpoint, don't change the PC Changing the PC confuses gdb, because execution does not continue where gdb expects it. Not changing the PC has the potential to confuse a stack dump, but when running under gdb it seems better to confuse a stack dump than to confuse gdb. Fixes issue 6776.

Patch Set 1 #

Patch Set 2 : diff -r 8a9da0007914 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/pkg/runtime/sys_x86.c View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 8
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
5 years, 10 months ago (2014-01-09 05:34:04 UTC) #1
dvyukov
Are we able to determine correct SPDELTA for the JMP instruction? I am looking at ...
5 years, 10 months ago (2014-01-09 09:24:10 UTC) #2
iant
On 2014/01/09 09:24:10, dvyukov wrote: > Are we able to determine correct SPDELTA for the ...
5 years, 10 months ago (2014-01-09 18:13:24 UTC) #3
dvyukov
On 2014/01/09 18:13:24, iant wrote: > On 2014/01/09 09:24:10, dvyukov wrote: > > Are we ...
5 years, 10 months ago (2014-01-13 15:24:44 UTC) #4
rsc
LGTM PCDATA is for custom pc-specific data. The sp-delta is handled internally and is correct.
5 years, 9 months ago (2014-02-12 18:42:56 UTC) #5
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=38cd458b1dfe *** runtime: if traceback sees a breakpoint, don't change the PC ...
5 years, 9 months ago (2014-02-14 19:06:57 UTC) #6
gobot
This CL appears to have broken the darwin-386 builder.
5 years, 9 months ago (2014-02-14 19:20:23 UTC) #7
iant
5 years, 9 months ago (2014-02-14 19:34:33 UTC) #8
On Fri, Feb 14, 2014 at 11:20 AM,  <gobot@golang.org> wrote:
> This CL appears to have broken the darwin-386 builder.
>
> https://codereview.appspot.com/49580044/

I doubt it.

--- FAIL: TestPipeLookPathLeak (0.02 seconds)
exec_test.go:228: leaked 4 fds; want ~0

Ian
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b