Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4097)

Issue 4955041: Shared locks

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by supertri
Modified:
2 weeks, 6 days ago
CC:
Ollie Wild
Visibility:
Public.

Patch Set 1 #

Total comments: 31

Patch Set 2 : Updated based on edits by reviewers, plus separated #

Total comments: 26

Patch Set 3 : Addressed reviewer comments, inc. new warning for different lock kinds #

Patch Set 4 : Fix enum names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -83 lines) Patch
M include/clang/Basic/DiagnosticSemaKinds.td View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M lib/Sema/AnalysisBasedWarnings.cpp View 1 2 3 18 chunks +152 lines, -64 lines 0 comments Download
M test/SemaCXX/warn-thread-safety-analysis.cpp View 1 2 6 chunks +100 lines, -16 lines 0 comments Download

Messages

Total messages: 8
Jeffrey Yasskin
http://codereview.appspot.com/4955041/diff/1/include/clang/Basic/DiagnosticSemaKinds.td File include/clang/Basic/DiagnosticSemaKinds.td (right): http://codereview.appspot.com/4955041/diff/1/include/clang/Basic/DiagnosticSemaKinds.td#newcode1402 include/clang/Basic/DiagnosticSemaKinds.td:1402: "expecting lock '%0' to be held at start of ...
9 years, 11 months ago (2011-08-26 19:20:47 UTC) #1
Jeffrey Yasskin
Whoops, forgot to +Ollie.
9 years, 11 months ago (2011-08-26 20:46:40 UTC) #2
supertri
http://codereview.appspot.com/4955041/diff/1/include/clang/Basic/DiagnosticSemaKinds.td File include/clang/Basic/DiagnosticSemaKinds.td (right): http://codereview.appspot.com/4955041/diff/1/include/clang/Basic/DiagnosticSemaKinds.td#newcode1402 include/clang/Basic/DiagnosticSemaKinds.td:1402: "expecting lock '%0' to be held at start of ...
9 years, 11 months ago (2011-09-01 18:47:08 UTC) #3
chandlerc
FYI, has this been mailed upstream? Definitely go ahead and mail it if not. Mostly ...
9 years, 11 months ago (2011-09-01 22:00:05 UTC) #4
supertri
This patch adds a warning if we acquire a lock with different kinds (exclusive vs. ...
9 years, 11 months ago (2011-09-02 20:54:16 UTC) #5
chandlerc
FYI, sorry the comments got stashed on the wrong thread. This is the one they ...
9 years, 11 months ago (2011-09-02 23:14:10 UTC) #6
supertri
http://codereview.appspot.com/4955041/diff/7001/lib/Sema/AnalysisBasedWarnings.cpp File lib/Sema/AnalysisBasedWarnings.cpp (right): http://codereview.appspot.com/4955041/diff/7001/lib/Sema/AnalysisBasedWarnings.cpp#newcode781 lib/Sema/AnalysisBasedWarnings.cpp:781: SHARED, On 2011/09/02 23:14:10, chandlerc wrote: > On 2011/09/02 ...
9 years, 11 months ago (2011-09-02 23:33:06 UTC) #7
chandlerc
9 years, 11 months ago (2011-09-02 23:47:49 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b