Issue 4951067: Update resumable upload sample to latest API.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4951067: Update resumable upload sample to latest API.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Ali Afshar

Modified:
12 years, 7 months ago

Reviewers:
Vic Fryzel, proppy, jcgregorio

CC:
gdata-python-client-library-contributors_googlegroups.com

Visibility:
Public.

Patch Set 2 : Updated the docs too. #

Total comments: 1

Patch Set 3 : Remove resumable upload sample and add set of samples with a sample runner. #

Total comments: 2

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+287 lines, -221 lines)			Patch
A	samples/docs/docs_v3_example.py	View	1 2	1 chunk	+243 lines, -0 lines	0 comments	Download
M	samples/docs/resumable_upload_sample.py	View	1 2	1 chunk	+0 lines, -221 lines	0 comments	Download
A	samples/docs/samplerunner.py	View	1 2	1 chunk	+44 lines, -0 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Vic Fryzel

http://codereview.appspot.com/4951067/diff/1002/samples/docs/resumable_upload_sample.py File samples/docs/resumable_upload_sample.py (right): http://codereview.appspot.com/4951067/diff/1002/samples/docs/resumable_upload_sample.py#newcode84 samples/docs/resumable_upload_sample.py:84: chunk_size=self.chunk_size, desired_class=gdata.docs.data.Resource) This whole sample is obsolete, because the ...

12 years, 7 months ago (2011-09-07 15:47:25 UTC) #3

Vic Fryzel

12 years, 7 months ago (2011-09-13 19:15:39 UTC) #5

LGTM

http://codereview.appspot.com/4951067/diff/2002/samples/docs/samplerunner.py
File samples/docs/samplerunner.py (right):

http://codereview.appspot.com/4951067/diff/2002/samples/docs/samplerunner.py#...
samples/docs/samplerunner.py:24: # This is a bit gnarly, but sound.
Remove this comment

http://codereview.appspot.com/4951067/diff/2002/samples/docs/samplerunner.py#...
samples/docs/samplerunner.py:37: for line in
lines[sample.func_code.co_firstlineno:]:
Add a comment above this line.

Expand All Messages | Collapse All Messages