Status command shows revision status

Status command shows revision status

juju status now shows the revision status of the service
and unit charms. If a service is running a charm different
than the charm store version, as determined by the charm
url, "can-upgrade-to" is shown. If a unit has a charm url
that is different to its parent service charm url, 
"upgrading-from" is shown. If a service is running a local
charm, no extra status is shown since comparing to a charm
store charm url doesn't make sense then.

The charm store revisions are updated periodically by a worker
which runs on the state server. The worker is  implemented 
in an upstream branch.

https://code.launchpad.net/~wallyworld/juju-core/status-charm-version/+merge/200949

Requires: https://code.launchpad.net/~wallyworld/juju-core/charm-version-worker/+merge/200948

(do not edit description out of merge proposal)

[wallyworld, 2014-01-09 04:12:17]

Please take a look.

[william.reade, 2014-01-13 09:20:29]

Hmm. "UpgradingFrom" in unit status would match "CanUpgradeTo" in service
status, if we decided to go that way. This is another for post-standup, I'm
afraid.

https://codereview.appspot.com/49510043/diff/1/cmd/juju/status.go
File cmd/juju/status.go (right):

https://codereview.appspot.com/49510043/diff/1/cmd/juju/status.go#newcode185
cmd/juju/status.go:185: RevisionStatus string               
`json:"charm-version,omitempty" yaml:"charm-version,omitempty"`
`CanUpgradeTo string` with an actual charm url, perhaps?

https://codereview.appspot.com/49510043/diff/1/cmd/juju/status.go#newcode279
cmd/juju/status.go:279: RevisionStatus: unit.RevisionStatus,
Huh, I thought we had a Charm in unit status already. I think it's better to
expose that, and only fill it in if it differs from its service's charm
(indicating an upgrade pending or in progress).

[wallyworld, 2014-01-16 05:33:17]

Please take a look.

[wallyworld, 2014-01-16 22:54:28]

I implemented the changes and added more tests

https://codereview.appspot.com/49510043/diff/1/cmd/juju/status.go
File cmd/juju/status.go (right):

https://codereview.appspot.com/49510043/diff/1/cmd/juju/status.go#newcode185
cmd/juju/status.go:185: RevisionStatus string               
`json:"charm-version,omitempty" yaml:"charm-version,omitempty"`
On 2014/01/13 09:20:29, william.reade wrote:
> `CanUpgradeTo string` with an actual charm url, perhaps? 

Yeah good idea. Done

https://codereview.appspot.com/49510043/diff/1/cmd/juju/status.go#newcode279
cmd/juju/status.go:279: RevisionStatus: unit.RevisionStatus,
On 2014/01/13 09:20:29, william.reade wrote:
> Huh, I thought we had a Charm in unit status already. I think it's better to
> expose that, and only fill it in if it differs from its service's charm
> (indicating an upgrade pending or in progress).

Also done., It is displayed as "upgrading-from" and shows the current out of
date charm url.

[thumper, 2014-01-17 01:11:42]

On 2014/01/16 22:54:28, wallyworld wrote:
> I implemented the changes and added more tests
> 
> https://codereview.appspot.com/49510043/diff/1/cmd/juju/status.go
> File cmd/juju/status.go (right):
> 
> https://codereview.appspot.com/49510043/diff/1/cmd/juju/status.go#newcode185
> cmd/juju/status.go:185: RevisionStatus string               
> `json:"charm-version,omitempty" yaml:"charm-version,omitempty"`
> On 2014/01/13 09:20:29, william.reade wrote:
> > `CanUpgradeTo string` with an actual charm url, perhaps? 
> 
> Yeah good idea. Done
> 
> https://codereview.appspot.com/49510043/diff/1/cmd/juju/status.go#newcode279
> cmd/juju/status.go:279: RevisionStatus: unit.RevisionStatus,
> On 2014/01/13 09:20:29, william.reade wrote:
> > Huh, I thought we had a Charm in unit status already. I think it's better to
> > expose that, and only fill it in if it differs from its service's charm
> > (indicating an upgrade pending or in progress).
> 
> Also done., It is displayed as "upgrading-from" and shows the current out of
> date charm url.

LGTM