Issue 4920044: Added code to check weather it is a subdomain if it is use the subdomain to issuue the request

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4920044: Added code to check weather it is a subdomain if it is use the subdomain to issuue the request

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by gunjansharma

Modified:
12 years, 8 months ago

Reviewers:
Claudio Cherubino, manoochehri, jcgregorio, Ali Afshar

CC:
gdata-python-client-library-contributors_googlegroups.com

Visibility:
Public.

Patch Set 2 : Changed the code to make it more robust #

Total comments: 2

Patch Set 3 : Changed the formatting errors #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	src/gdata/apps/emailsettings/client.py	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Claudio Cherubino

http://codereview.appspot.com/4920044/diff/3001/src/gdata/apps/emailsettings/client.py File src/gdata/apps/emailsettings/client.py (right): http://codereview.appspot.com/4920044/diff/3001/src/gdata/apps/emailsettings/client.py#newcode126 src/gdata/apps/emailsettings/client.py:126: username, setting_id) indent this line correctly and you can ...

12 years, 8 months ago (2011-08-24 17:07:59 UTC) #3

Ali Afshar

LGTM http://codereview.appspot.com/4920044/diff/3001/src/gdata/apps/emailsettings/client.py File src/gdata/apps/emailsettings/client.py (right): http://codereview.appspot.com/4920044/diff/3001/src/gdata/apps/emailsettings/client.py#newcode122 src/gdata/apps/emailsettings/client.py:122: username, domain = username.split('@',1) Space after ,

12 years, 8 months ago (2011-08-24 17:11:34 UTC) #4

Expand All Messages | Collapse All Messages