Issue 49090043: code review 49090043: libmach: use different names for different Ureg types

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49090043: code review 49090043: libmach: use different names for different Ureg types (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
jsing, iant

CC:
golang-codereviews, jsing, 0intro, iant

Visibility:
Public.

Description

libmach: use different names for different Ureg types Everything was doing this already with #defines. Do it right.

Patch Set 1 #

Patch Set 2 : diff -r 65a1b6a436af https://code.google.com/p/go/ #

Patch Set 3 : diff -r 65a1b6a436af https://code.google.com/p/go/ #

Patch Set 4 : diff -r 04840085a1e1 https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -103 lines)			Patch
M	include/ureg_amd64.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	include/ureg_arm.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	include/ureg_x86.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/prof/main.c	View	1	5 chunks	+9 lines, -14 lines	0 comments	Download
M	src/libmach/5.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/libmach/5db.c	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/libmach/6.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/libmach/8.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/libmach/8db.c	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/libmach/darwin.c	View	1	3 chunks	+34 lines, -41 lines	0 comments	Download
M	src/libmach/linux.c	View	1 2	3 chunks	+24 lines, -30 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2014-01-08 16:36:50 UTC) #1

0intro

I observe these compilation errors on Plan 9: src/libmach/8.c:50 structure not fully declared Ureg386 src/libmach/5.c:47 ...

11 years, 6 months ago (2014-01-08 21:14:38 UTC) #3

rsc

11 years, 6 months ago (2014-01-09 01:37:31 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=ee4d38d99fa8 ***

libmach: use different names for different Ureg types

Everything was doing this already with #defines.
Do it right.

R=golang-codereviews, jsing, 0intro, iant
CC=golang-codereviews
https://codereview.appspot.com/49090043

Expand All Messages | Collapse All Messages