Issue 4908050: Fix atoms for chrome. Also, add target type js_fragment_cpp which splits the

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4908050: Fix atoms for chrome. Also, add target type js_fragment_cpp which splits the

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by kkania1

Modified:
12 years, 8 months ago

Reviewers:
Eran

Base URL:
http://selenium.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix atoms for chrome. Also, add target type js_fragment_cpp which splits the source and header files. This follows chromium style for constants and hopefully compiles faster.

Patch Set 1 : '' #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -23 lines)			Patch
	M	javascript/chrome-driver/build.desc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	rake-tasks/crazy_fun/mappings/javascript.rb	View		8 chunks	+108 lines, -22 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kkania1

feel free to pick a different reviewer; I just saw that you were the last ...

12 years, 8 months ago (2011-08-17 22:26:10 UTC) #1

kkania1

It seems Simon is too busy. Eran, do you have time to review this? This ...

12 years, 8 months ago (2011-08-18 16:19:22 UTC) #2

Eran

On 2011/08/19 15:30:48, kkania1 wrote: > ping LGTM. However, applying the patch failed. Can you ...

12 years, 8 months ago (2011-08-22 13:42:22 UTC) #4

Committed in r13486.

Expand All Messages | Collapse All Messages