Issue 49042: Work around windows.h #defining GetMessage().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49042: Work around windows.h #defining GetMessage().

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by kenton

Modified:
14 years, 9 months ago

Reviewers:

Base URL:
http://protobuf.googlecode.com/svn/trunk/

Visibility:
Public.

Description

windows.h #defines GetMessage() as a macro. Protocol Buffers uses GetMessage() as a method name. These are incompatible. We can work around it without inconveniencing users by converting the GetMessage macro into an inline function.

Patch Set 1 #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -0 lines)			Patch
M	src/google/protobuf/message.h	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/google/protobuf/test_util.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/google/protobuf/testing/googletest.h	View	1 chunk	+1 line, -0 lines	0 comments	Download