code review 4890042: xml: Escape string chardata in xml.Marshal

xml: Escape string chardata in xml.Marshal

Fixes issue 2150.

[Kyle Lemons, 2011-08-13 19:04:36]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[nigeltao, 2011-08-17 06:38:45]

On 2011/08/13 19:04:36, Kyle Lemons wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

LGTM.

[nigeltao, 2011-08-17 06:42:11]

On 2011/08/17 06:38:45, nigeltao wrote:
> On 2011/08/13 19:04:36, Kyle Lemons wrote:
> > Hello mailto:golang-dev@googlegroups.com (cc:
> mailto:golang-dev@googlegroups.com),
> > 
> > I'd like you to review this change to
> > https://go.googlecode.com/hg/
> 
> LGTM.

Kyle -- please either re-submit this CL as <kyle@kylelemons.net> or
<kevlar@google.com>, or sign the CLA as <etherealflaim@gmail.com>.

[rsc, 2011-08-17 16:01:56]

On Wed, Aug 17, 2011 at 02:42, <nigeltao@golang.org> wrote:
> On 2011/08/17 06:38:45, nigeltao wrote:
>>
>> On 2011/08/13 19:04:36, Kyle Lemons wrote:
>> > Hello mailto:golang-dev@googlegroups.com (cc:
>> mailto:golang-dev@googlegroups.com),
>> >
>> > I'd like you to review this change to
>> > https://go.googlecode.com/hg/
>
>> LGTM.
>
> Kyle -- please either re-submit this CL as <kyle@kylelemons.net> or
> <kevlar@google.com>, or sign the CLA as <etherealflaim@gmail.com>.
>
> http://codereview.appspot.com/4890042/

I will submit this under kyle@kylelemons.net.
(You run hg clpatch and then edit .hg/codereview/cl.4890042
to change the Author: line.)
Kyle, if you are going to switch to using
your gmail address for code reviews, please
let us know so that we can update the contributors
file.  You do not have to sign a CLA.

Russ

[rsc, 2011-08-17 16:12:13]

*** Submitted as http://code.google.com/p/go/source/detail?r=e7bbaa4eae1f ***

xml: escape string chardata in xml.Marshal

Fixes issue 2150.

R=golang-dev, nigeltao, rsc
CC=golang-dev
http://codereview.appspot.com/4890042

Committer: Russ Cox <rsc@golang.org>