Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 4889046: Added RED queue

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by talau
Modified:
10 years, 7 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 41

Patch Set 2 : fixes suggested by Duy and others changes #

Total comments: 38

Patch Set 3 : work in red-queue reviews #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1682 lines, -0 lines) Patch
A src/network/examples/red-tests.cc View 1 2 1 chunk +488 lines, -0 lines 0 comments Download
M src/network/examples/wscript View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/network/test/examples-to-run.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/network/test/red-queue-test-suite.cc View 1 2 1 chunk +280 lines, -0 lines 0 comments Download
A src/network/utils/red-queue.h View 1 2 1 chunk +261 lines, -0 lines 0 comments Download
A src/network/utils/red-queue.cc View 1 2 1 chunk +646 lines, -0 lines 0 comments Download
M src/network/wscript View 1 2 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14
Duy
http://codereview.appspot.com/4889046/diff/1/src/network/examples/red-tests.cc File src/network/examples/red-tests.cc (right): http://codereview.appspot.com/4889046/diff/1/src/network/examples/red-tests.cc#newcode25 src/network/examples/red-tests.cc:25: */ this is great that we provide the plotting ...
10 years, 10 months ago (2011-08-18 08:01:26 UTC) #1
talau
Small comments in Review by Duy; thanks :D http://codereview.appspot.com/4889046/diff/1/src/network/utils/red-queue.cc File src/network/utils/red-queue.cc (right): http://codereview.appspot.com/4889046/diff/1/src/network/utils/red-queue.cc#newcode96 src/network/utils/red-queue.cc:96: "True ...
10 years, 10 months ago (2011-08-22 17:54:41 UTC) #2
Peter Barnes
Mostly minor spelling in comments. Move documentation of m_qW flags to header? Document m_cautious = ...
10 years, 10 months ago (2011-09-02 17:21:35 UTC) #3
Duy
Some minor comments, other than that I think it's ready. http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-test-suite.cc File src/network/test/red-queue-test-suite.cc (right): http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-test-suite.cc#newcode32 ...
10 years, 9 months ago (2011-10-02 00:05:03 UTC) #4
Duy
http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-test-suite.cc File src/network/test/red-queue-test-suite.cc (right): http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-test-suite.cc#newcode32 src/network/test/red-queue-test-suite.cc:32: { I ran this on your test-suite ./test.py -g ...
10 years, 9 months ago (2011-10-02 00:33:26 UTC) #5
John Abraham
As this implementation is inclined towards the implementation in ns-2 / Floyd's papers, please cite ...
10 years, 7 months ago (2011-11-09 00:08:27 UTC) #6
talau
http://codereview.appspot.com/4889046/diff/5001/src/network/utils/red-queue.cc File src/network/utils/red-queue.cc (left): http://codereview.appspot.com/4889046/diff/5001/src/network/utils/red-queue.cc#oldcode184 src/network/utils/red-queue.cc:184: m_minTh = min; On 2011/11/09 00:08:27, John Abraham wrote: ...
10 years, 7 months ago (2011-11-18 13:19:30 UTC) #7
talau
http://codereview.appspot.com/4889046/diff/5001/src/network/utils/red-queue.h File src/network/utils/red-queue.h (right): http://codereview.appspot.com/4889046/diff/5001/src/network/utils/red-queue.h#newcode200 src/network/utils/red-queue.h:200: // Min avg length threshold (bytes), should be >= ...
10 years, 7 months ago (2011-11-18 13:45:43 UTC) #8
talau
http://codereview.appspot.com/4889046/diff/5001/src/network/examples/red-tests.cc File src/network/examples/red-tests.cc (right): http://codereview.appspot.com/4889046/diff/5001/src/network/examples/red-tests.cc#newcode112 src/network/examples/red-tests.cc:112: // Clientes are in left side On 2011/09/02 17:21:35, ...
10 years, 7 months ago (2011-11-18 14:00:19 UTC) #9
Duy
http://codereview.appspot.com/4889046/diff/5001/src/network/utils/red-queue.cc File src/network/utils/red-queue.cc (right): http://codereview.appspot.com/4889046/diff/5001/src/network/utils/red-queue.cc#newcode215 src/network/utils/red-queue.cc:215: uint32_t nQueued; My compiler is giving me warning about ...
10 years, 7 months ago (2011-11-18 16:27:18 UTC) #10
talau
http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-test-suite.cc File src/network/test/red-queue-test-suite.cc (right): http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-test-suite.cc#newcode32 src/network/test/red-queue-test-suite.cc:32: { On 2011/10/02 00:33:26, Duy wrote: > I ran ...
10 years, 7 months ago (2011-11-27 16:02:05 UTC) #11
talau
http://codereview.appspot.com/4889046/diff/1/src/network/utils/red-queue.cc File src/network/utils/red-queue.cc (right): http://codereview.appspot.com/4889046/diff/1/src/network/utils/red-queue.cc#newcode181 src/network/utils/red-queue.cc:181: RedQueue::SetTh(double min, double max) On 2011/11/09 00:08:27, John Abraham ...
10 years, 7 months ago (2011-11-27 16:16:29 UTC) #12
Duy
http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-test-suite.cc File src/network/test/red-queue-test-suite.cc (right): http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-test-suite.cc#newcode32 src/network/test/red-queue-test-suite.cc:32: { I think it's only specific to the red-queue ...
10 years, 7 months ago (2011-11-27 17:27:42 UTC) #13
John Abraham
10 years, 7 months ago (2011-12-05 15:45:14 UTC) #14
Are these leaks or "still reachable" errors?
I tried it out, I found "still reachable" errors, the fix was to add
"Simulator::Destroy" after "RunRedTests".

On 2011/11/27 17:27:42, Duy wrote:
>
http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-te...
> File src/network/test/red-queue-test-suite.cc (right):
> 
>
http://codereview.appspot.com/4889046/diff/5001/src/network/test/red-queue-te...
> src/network/test/red-queue-test-suite.cc:32: {
> I think it's only specific to the red-queue tests?  There is memory leaks in
it.
>  If you try running it on drop-tail-queue, you won't see any memory leaks.  
> 
> On 2011/11/27 16:02:05, talau wrote:
> > On 2011/10/02 00:33:26, Duy wrote:
> > > I ran this on your test-suite
> > > ./test.py -g -v -s red-queue -t error.txt
> > > 
> > > and got valgrind errors, could you take a look again?
> > > 
> > please, what error do you found? is this only in red-queue tests? like: 
> > ./test.py -g -v -s drop-tail-queue -t error.txt
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b