Issue 48670045: state: fix Environ life assertion to handle null

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 48670045: state: fix Environ life assertion to handle null

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by axw

Modified:
10 years, 4 months ago

Reviewers:
mp+200759, jameinel

Visibility:
Public.

Description

state: fix Environ life assertion to handle null If the life field is missing, it should be considered Alive. Fixes #1266748 https://code.launchpad.net/~axwalk/juju-core/lp1266748-state-environment-isalive-1.16/+merge/200759 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : state: fix Environ life assertion to handle null #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -2 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	state/compat_test.go	View	1	1 chunk	+68 lines, -0 lines	0 comments	Download
M	state/environ.go	View		2 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

LGTM, with a small question. (most of the unset examples I've seen do pass something, ...

10 years, 4 months ago (2014-01-09 10:24:20 UTC) #2

axw

10 years, 4 months ago (2014-01-09 10:40:52 UTC) #3

Please take a look.

https://codereview.appspot.com/48670045/diff/1/state/compat_test.go
File state/compat_test.go (right):

https://codereview.appspot.com/48670045/diff/1/state/compat_test.go#newcode57
state/compat_test.go:57: Update: D{{"$unset", D{{"life", Dying}}}},
On 2014/01/09 10:24:21, jameinel wrote:
> It seems odd to pass a value here for unset.

Changed to nil.

Expand All Messages | Collapse All Messages