Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8710)

Issue 4855043: Advanced Touch API - Up gesture

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by juantrujillo
Modified:
12 years, 8 months ago
Reviewers:
Eran, berrada
CC:
webdriver-eng_google.com
Base URL:
http://selenium.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Advanced Touch API - Gesture Up - Minor comments #

Patch Set 3 : Advanced Touch API - Up gesture #

Total comments: 1

Patch Set 4 : Up gesture #

Messages

Total messages: 7
juantrujillo
12 years, 8 months ago (2011-08-07 21:19:25 UTC) #1
berrada
Same comments as previous CL. Looks good otherwise. On 2011/08/07 21:19:25, juantrujillo wrote:
12 years, 8 months ago (2011-08-08 21:29:26 UTC) #2
juantrujillo
12 years, 8 months ago (2011-08-12 23:52:56 UTC) #3
juantrujillo
12 years, 8 months ago (2011-08-17 17:01:04 UTC) #4
berrada
http://codereview.appspot.com/4855043/diff/5001/android/src/java/org/openqa/selenium/android/AndroidTouchScreen.java File android/src/java/org/openqa/selenium/android/AndroidTouchScreen.java (right): http://codereview.appspot.com/4855043/diff/5001/android/src/java/org/openqa/selenium/android/AndroidTouchScreen.java#newcode41 android/src/java/org/openqa/selenium/android/AndroidTouchScreen.java:41: public AndroidTouchScreen(ActivityController controller, AndroidDriver driver) { Please update your ...
12 years, 8 months ago (2011-08-17 20:39:18 UTC) #5
juantrujillo
12 years, 8 months ago (2011-08-18 23:54:10 UTC) #6
berrada
12 years, 8 months ago (2011-08-19 00:35:51 UTC) #7
LGTM , submitted in r13452

On Thu, Aug 18, 2011 at 4:54 PM, <juantrujillo@google.com> wrote:

>
http://codereview.appspot.com/**4855043/<http://codereview.appspot.com/4855043/>
>



-- 
Dounia
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b