Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(601)

Issue 48540043: Fix a bug that killed the worker.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by bac
Modified:
6 years, 3 months ago
Reviewers:
rharding, mp+200710
Visibility:
Public.

Description

Fix a bug that killed the worker. Fixed 'wait_seconds' and added missing tests. Added stanzas for logging that are required until the production overrides in the charm are brought in. QA: run 'bin/ingest-queued --limit=10 --debug --run-forever' and see that it waits before proceeding. https://code.launchpad.net/~bac/charmworld/fix-logging/+merge/200710 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -17 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/jobs/lp.py View 6 chunks +10 lines, -5 lines 0 comments Download
M charmworld/jobs/tests/test_worker.py View 3 chunks +36 lines, -0 lines 0 comments Download
M charmworld/jobs/worker.py View 4 chunks +13 lines, -6 lines 0 comments Download
M default.ini View 3 chunks +11 lines, -5 lines 1 comment Download
M scripts/ingest View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 4
bac
Please take a look.
6 years, 3 months ago (2014-01-07 18:29:57 UTC) #1
rharding
Code looks ok though I'm not a fan of the log id rename. Will QA ...
6 years, 3 months ago (2014-01-07 18:42:58 UTC) #2
rharding
QA ok thanks!
6 years, 3 months ago (2014-01-07 19:34:26 UTC) #3
rharding
6 years, 3 months ago (2014-01-07 19:54:03 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b