code review 48520043: crypto/sha512: prevent duplicate block declaration on 386

crypto/sha512: avoid duplicate block declaration on 386

Unbreak the build - we do not have a sha512 block implementation in
386 assembly (yet).

[jsing, 2014-01-07 12:43:09]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2014-01-07 12:47:18]

LGTM. Thank you.


On Tue, Jan 7, 2014 at 11:43 PM, <jsing@google.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> crypto/sha512: prevent duplicate block declaration on 386
>
> Unbreak the build - we do not have an assembly block implementation
> for 386 (yet).
>
> Please review this at https://codereview.appspot.com/48520043/
>
> Affected files (+1, -1 lines):
>   M src/pkg/crypto/sha512/sha512block_decl.go
>
>
> Index: src/pkg/crypto/sha512/sha512block_decl.go
> ===================================================================
> --- a/src/pkg/crypto/sha512/sha512block_decl.go
> +++ b/src/pkg/crypto/sha512/sha512block_decl.go
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -// +build 386 amd64
> +// +build amd64
>
>  package sha512
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[jsing, 2014-01-07 12:50:39]

*** Submitted as https://code.google.com/p/go/source/detail?r=35ffa836a462 ***

crypto/sha512: avoid duplicate block declaration on 386

Unbreak the build - we do not have a sha512 block implementation in
386 assembly (yet).

R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/48520043