Issue 4850045: co: new package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4850045: co: new package

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by dvyukov

Modified:
12 years, 8 months ago

Reviewers:
Kyle C, dvyukov

Visibility:
Public.

Description

co: new package

Patch Set 1 #

Patch Set 2 : diff -r 6f83246236f3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f9491b73dcf7 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r d499fb951a9e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r d499fb951a9e https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1175 lines, -37 lines)			Patch
M	src/pkg/Makefile	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/pkg/co/Makefile	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A	src/pkg/co/distributedrwmutex.go	View	1	1 chunk	+83 lines, -0 lines	0 comments	Download
A	src/pkg/co/distributedrwmutex_test.go	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download
A	src/pkg/co/resourcecache.go	View	1 2	1 chunk	+181 lines, -0 lines	0 comments	Download
A	src/pkg/co/resourcecache_test.go	View	1	1 chunk	+241 lines, -0 lines	0 comments	Download
A	src/pkg/co/statcounter.go	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
A	src/pkg/co/statcounter_test.go	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download
A	src/pkg/co/sysconf.go	View	1 2	1 chunk	+69 lines, -0 lines	0 comments	Download
A	src/pkg/co/sysconf_darwin.go	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download
A	src/pkg/co/sysconf_freebsd.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	src/pkg/co/sysconf_linux.go	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
A	src/pkg/co/sysconf_plan9.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	src/pkg/co/sysconf_test.go	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
A	src/pkg/co/sysconf_windows.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	src/pkg/co/test.go	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/pkg/fmt/fmt_test.go	View	1	2 chunks	+22 lines, -0 lines	0 comments	Download
M	src/pkg/fmt/print.go	View	1 2	3 chunks	+4 lines, -34 lines	0 comments	Download
M	src/pkg/fmt/scan.go	View	1 2	4 chunks	+4 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/Makefile	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/mem.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/proclocal.c	View	1	1 chunk	+166 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/proclocal_test.go	View	1	1 chunk	+114 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Kyle C

12 years, 8 months ago (2011-08-08 19:35:27 UTC) #1

Minor point.

http://codereview.appspot.com/4850045/diff/3001/src/pkg/co/sysconf.go
File src/pkg/co/sysconf.go (right):

http://codereview.appspot.com/4850045/diff/3001/src/pkg/co/sysconf.go#newcode45
src/pkg/co/sysconf.go:45: idx := bytes.Index(info,
bytes.NewBufferString(param).Bytes())
idx := bytes.Index(info, []byte(param))

perhaps?
Same elsewhere.

Expand All Messages | Collapse All Messages