Issue 48500044: code review 48500044: cmd/nm: add -sort=size

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 48500044: code review 48500044: cmd/nm: add -sort=size (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by r

Modified:
11 years, 6 months ago

Reviewers:
rsc

CC:
golang-codereviews, gobot, rsc

Visibility:
Public.

Description

cmd/nm: add -sort=size When printing the size, we often want to sort on that key. Because it's used when looking for large things, make the sort go from largest to smallest. Perfect recreation of CL 45150044, which was lost to some blunder.

Patch Set 1 #

Patch Set 2 : diff -r db95cbe91420 https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	src/cmd/nm/doc.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/cmd/nm/nm.go	View		3 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2014-01-07 17:46:40 UTC) #1

11 years, 6 months ago (2014-01-08 23:56:43 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=04840085a1e1 ***

cmd/nm: add -sort=size
When printing the size, we often want to sort on that key.
Because it's used when looking for large things, make the
sort go from largest to smallest.

Perfect recreation of CL 45150044, which was lost to some blunder.

R=golang-codereviews, gobot, rsc
CC=golang-codereviews
https://codereview.appspot.com/48500044

Expand All Messages | Collapse All Messages