Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1780)

Issue 4849052: Add getPageZoom chrome-specific js atom. Needed to convert client coordinates

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by kkania1
Modified:
12 years, 8 months ago
Reviewers:
Eran
Base URL:
http://selenium.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add getPageZoom chrome-specific js atom. Also, don't truncate the result of getLocationInView.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M javascript/chrome-driver/atoms.js View 2 chunks +19 lines, -5 lines 0 comments Download
M javascript/chrome-driver/build.desc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7
kkania1
12 years, 8 months ago (2011-08-09 16:02:44 UTC) #1
Eran
The code itself LGTM. Do you have a test case for it? It may be ...
12 years, 8 months ago (2011-08-10 09:28:45 UTC) #2
kkania1
I only did manual testing. I can simulate zoom with sendKeys with native events turned ...
12 years, 8 months ago (2011-08-10 16:43:14 UTC) #3
Eran
Sounds like testing on the ChromeDriver side is easier. I would use native events - ...
12 years, 8 months ago (2011-08-11 13:37:24 UTC) #4
kkania1
Ok, I'll write a test on the chromedriver side and CC you. Can you go ...
12 years, 8 months ago (2011-08-15 23:45:39 UTC) #5
Eran
Will do. On Tue, Aug 16, 2011 at 12:45 AM, <kkania@chromium.org> wrote: > Ok, I'll ...
12 years, 8 months ago (2011-08-16 14:39:03 UTC) #6
Eran
12 years, 8 months ago (2011-08-17 15:00:24 UTC) #7
Submitted in r13412.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b