The code itself LGTM. Do you have a test case for it? It may be ...
12 years, 8 months ago
(2011-08-10 09:28:45 UTC)
#2
The code itself LGTM. Do you have a test case for it? It may be possible to
create one by sending the keyboard shortcut for zoom-in / out with sendKeys.
I only did manual testing. I can simulate zoom with sendKeys with native events turned ...
12 years, 8 months ago
(2011-08-10 16:43:14 UTC)
#3
I only did manual testing. I can simulate zoom with sendKeys with native events
turned on, but I'm not sure how to write a test that uses ChromeDriver and this
atom in the webdriver repo. I suppose I would have to tweak the atom compiler
code to also generate some version of this atom which could be put in a
generated test html page or read in and executed by the test.
Or I could just test this on the ChromeDriver side. I'm not sure exactly how I'd
do it there though either. I don't want to use native events because they are
flaky on our test machines. I suppose I could add a capability to allow regular
events to be processed by the browser as well as the renderer...
Any thoughts?
Sounds like testing on the ChromeDriver side is easier. I would use native events - ...
12 years, 8 months ago
(2011-08-11 13:37:24 UTC)
#4
Sounds like testing on the ChromeDriver side is easier. I would use native
events - perhaps turn them on only for this test. See the
NativeEventsFirefoxDriverTestSuite - where we create an instance of the
FirefoxDriver with native events turned on and run the tests. We know that some
tests are prone to failure with native events and that some tests only make
sense with native events turned on.
I've found that flakiness when testing with native events happens because the
browser has not finished processing all the events. For such tests, I add a wait
statement that constantly checks the expected condition until it's met (or a
timeout has expired).
Issue 4849052: Add getPageZoom chrome-specific js atom. Needed to convert client coordinates
Created 12 years, 8 months ago by kkania1
Modified 12 years, 8 months ago
Reviewers: Eran
Base URL: http://selenium.googlecode.com/svn/trunk/
Comments: 0